Fix PR review comments

- relative path instead of absolute + all verified txt files
- remove net462 preprocessor symbols from test

Author: milkshakeuk

tests/NHapi.NUnit.SourceGeneration/Generators/BaseDataTypeGeneratorTests.cs

@@ -2,6 +2,7 @@ namespace NHapi.NUnit.SourceGeneration.Generators
 {
     using System.Collections.Concurrent;
     using System.Collections.Generic;
+    using System.IO;
     using System.Text;
     using System.Threading.Tasks;
 
@@ -35,6 +36,7 @@ public async Task BuildBaseDataTypes_GeneratesBaseDataTypes(string version)
 
             FileAbstraction.UsingImplementation((filePath, bytes) =>
             {
+                filePath = Path.GetRelativePath(Directory.GetCurrentDirectory(), filePath);
                 results.TryAdd(filePath, Encoding.UTF8.GetString(bytes));
             });
 

tests/NHapi.NUnit.SourceGeneration/Generators/DataTypeGeneratorTests.cs

@@ -48,6 +48,7 @@ public async Task MakeAll_GeneratesAllDataTypes(string version)
 
             FileAbstraction.UsingImplementation((filePath, bytes) =>
             {
+                filePath = Path.GetRelativePath(Directory.GetCurrentDirectory(), filePath);
                 results.TryAdd(filePath, Encoding.UTF8.GetString(bytes));
             });
 

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_21.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V21\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V21\EventMapping\EventMap.properties:
 #event -> structure map for 2.1
 #note: no mappings are defined for 2.1 and 2.2
 

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_22.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V22\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V22\EventMapping\EventMap.properties:
 #event -> structure map for 2.2
 #note: no mappings are defined for 2.1 and 2.2
 

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_23.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V23\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V23\EventMapping\EventMap.properties:
 #event -> structure map for 2.3
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_231.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V231\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V231\EventMapping\EventMap.properties:
 #event -> structure map for 2.3.1
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_24.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V24\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V24\EventMapping\EventMap.properties:
 #event -> structure map for 2.4
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_25.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V25\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V25\EventMapping\EventMap.properties:
 #event -> structure map for 2.5
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_251.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V251\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V251\EventMapping\EventMap.properties:
 #event -> structure map for 2.5.1
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02

tests/NHapi.NUnit.SourceGeneration/Generators/EventMappingGeneratorTests.MakeAll_GeneratesAllEventMaps_26.verified.txt

@@ -1,5 +1,5 @@
 {
-  C:\DEV\nHapiNet\nHapi\tests\NHapi.NUnit.SourceGeneration\bin\Debug\net8.0\basepath\NHapi.Model.V26\EventMapping\EventMap.properties:
+  basepath\NHapi.Model.V26\EventMapping\EventMap.properties:
 #event -> structure map for 2.6
 ADT_A01 ADT_A01
 ADT_A02 ADT_A02