refactor: remove the TransportsSenderActor #3644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3644/docs/iroh/ Last updated: 2025-11-11T13:01:32Z |
Contributor
Right, but that's gone in #3595. I wonder if we should keep the issue open until that is merged so we can re-visit it? It would mean the TransportsSender disappears from a bunch of constructors to plug it through I think. |
Contributor
Author
|
sure |
dignifiedquire
force-pushed
the
feat-multipath-rm-transports-actor-sender
branch
from
d3c2648 to
b9d063f
Compare
flub
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #3641, the rest can be done once quic holepunching has landed
Unfortunately
send_disco_messagealso needs the sender, so it can't be fully removed from theEndpointState