Skip to content

Commit 258eb33

Browse files
authored
chore(ci): fix uploads of release artifacts again (#2893)
## Description This is getting very annoying but very inconvenient to test and docs & alignment between GHA and platform is less than ideal. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
1 parent a4ad7a2 commit 258eb33

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ jobs:
255255
ASSETS+="$staging.tar.gz,"
256256
done
257257
echo "ASSET=$(echo $ASSETS | sed 's/,$//')" >> $GITHUB_ENV
258-
echo "ASSET_MULTI_LINE=$(echo $ASSETS | sed 's/,/\\n/g')" >> $GITHUB_ENV
259258
260259
- name: Build archives (windows)
261260
if: matrix.os == 'windows-latest'
@@ -273,9 +272,7 @@ jobs:
273272
Set-Location -Path ..
274273
}
275274
$ASSETS = $ASSETS -join ','
276-
$ASSETS_MULTI_LINE = $ASSETS -replace ',', "`n"
277275
Add-Content -Path $env:GITHUB_ENV -Value "ASSET=$ASSETS"
278-
Add-Content -Path $env:GITHUB_ENV -Value "ASSET_MULTI_LINE=$ASSETS_MULTI_LINE"
279276
280277
- uses: n0-computer/actions-upload-release-asset@main
281278
if: (github.event.inputs.upload_artifacts == 'true' || github.event_name == 'push')
@@ -287,8 +284,7 @@ jobs:
287284
uses: actions/upload-artifact@v4
288285
with:
289286
name: iroh-${{env.RELEASE_OS }}-${{env.RELEASE_ARCH}}-bundle
290-
path: |
291-
${{ env.ASSET_MULTI_LINE }}
287+
path: iroh-*{.tar.gz,.zip}
292288
compression-level: 0
293289

294290
docker:

0 commit comments

Comments
 (0)