refactor: Move the simple node from test scope to behind a feature flag #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use it not just from tests but also from examples
rklaehn
commented
Nov 21, 2024
| testdir = "0.9.1" | ||
|
|
||
| [features] | ||
| default = ["fs-store", "rpc", "net_protocol"] |
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/16/docs/iroh_blobs/ Last updated: 2024-11-21T15:41:39Z |
Collaborator
Author
|
We want to expose people to the router API in the examples instead of having a self-contained Node that is not extendable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the simple node from test scope to behind a feature flag and use it not just from tests but also from examples
Breaking Changes
Notes & open questions
Change checklist