fix: Export try reference bugfix #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to move the file from an external location, but copy if external!
We don't want to move, but to copy in that case. We also update the db, but limit the max number of external paths to MAX_EXTERNAL_PATHS This fixes a regression from blobs 0.35 regarding ExportMode::TryReference
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/149/docs/iroh_blobs/ Last updated: 2025-09-17T08:00:06Z |
also clippy
dignifiedquire
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't want to move, but to copy in that case.
We also update the db, but limit the max number of external paths to MAX_EXTERNAL_PATHS
This fixes a regression from blobs 0.35 regarding ExportMode::TryReference
Fixes n0-computer/sendme#103
Breaking Changes
None
Notes & open questions
Change checklist