refactor: hide or remove unused code. #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature flag into a separate crate eventually. - Make util pub(crate) - Remove unused code in the hash_seq module
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/115/docs/iroh_blobs/ Last updated: 2025-07-11T15:28:25Z |
ChunkRangeExt is really the only thing we need out of util. Eventually I might have to newtype ChunkRanges even though that would be a PITA.
people are confused how to obtain an API instance to work with, so this give them pointers.
b5
approved these changes
Jul 11, 2025
Member
b5
left a comment
b5
left a comment
There was a problem hiding this comment.
I don't see anything controversial here. Feel free to wait for a professional to approve first 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist