add a test for rename

Author: rklaehn

src/rpc/client/tags.rs

@@ -289,6 +289,15 @@ where
         self.delete_with_opts(DeleteOptions::prefix(prefix.as_ref()))
             .await
     }
+
+    /// Delete all tags. Use with care. After this, all data will be garbage collected.
+    pub async fn delete_all(&self) -> Result<()> {
+        self.delete_with_opts(DeleteOptions {
+            from: None,
+            to: None,
+        })
+        .await
+    }
 }
 
 /// Information about a tag.
@@ -303,6 +312,17 @@ pub struct TagInfo {
 }
 
 impl TagInfo {
+    /// Create a new tag info.
+    pub fn new(name: impl AsRef<[u8]>, value: impl Into<HashAndFormat>) -> Self {
+        let name = name.as_ref();
+        let value = value.into();
+        Self {
+            name: Tag::from(name),
+            hash: value.hash,
+            format: value.format,
+        }
+    }
+
     /// Get the hash and format of the tag.
     pub fn hash_and_format(&self) -> HashAndFormat {
         HashAndFormat {

tests/tags.rs

@@ -8,7 +8,7 @@ use iroh_blobs::{
         client::tags::{self, TagInfo},
         proto::RpcService,
     },
-    BlobFormat, Hash, HashAndFormat,
+    Hash, HashAndFormat,
 };
 use testresult::TestResult;
 
@@ -19,11 +19,7 @@ async fn to_vec<T>(stream: impl Stream<Item = anyhow::Result<T>>) -> anyhow::Res
 
 fn expected(tags: impl IntoIterator<Item = &'static str>) -> Vec<TagInfo> {
     tags.into_iter()
-        .map(|tag| TagInfo {
-            name: tag.into(),
-            hash: Hash::new(tag),
-            format: BlobFormat::Raw,
-        })
+        .map(|tag| TagInfo::new(tag, Hash::new(tag)))
         .collect()
 }
 
@@ -89,11 +85,7 @@ async fn tags_smoke<C: quic_rpc::Connector<RpcService>>(tags: tags::Client<C>) -
 
     assert_eq!(
         tags.get("b").await?,
-        Some(TagInfo {
-            name: "b".into(),
-            hash: Hash::new("b"),
-            format: BlobFormat::Raw,
-        })
+        Some(TagInfo::new("b", Hash::new("b")))
     );
 
     tags.delete("b").await?;
@@ -103,21 +95,32 @@ async fn tags_smoke<C: quic_rpc::Connector<RpcService>>(tags: tags::Client<C>) -
 
     assert_eq!(tags.get("b").await?, None);
 
-    tags.delete_prefix("").await?;
+    tags.delete_all().await?;
 
     tags.set("a", HashAndFormat::hash_seq(Hash::new("a")))
         .await?;
     tags.set("b", HashAndFormat::raw(Hash::new("b"))).await?;
     let stream = tags.list_hash_seq().await?;
     let res = to_vec(stream).await?;
-    assert_eq!(
-        res,
-        vec![TagInfo {
-            name: "a".into(),
-            hash: Hash::new("a"),
-            format: BlobFormat::HashSeq,
-        },]
-    );
+    assert_eq!(res, vec![TagInfo {
+        name: "a".into(),
+        hash: Hash::new("a"),
+        format: iroh_blobs::BlobFormat::HashSeq,
+    }]);
+
+    tags.delete_all().await?;
+    set(&tags, ["c"]).await?;
+    tags.rename("c", "f").await?;
+    let stream = tags.list().await?;
+    let res = to_vec(stream).await?;
+    assert_eq!(res, vec![TagInfo {
+        name: "f".into(),
+        hash: Hash::new("c"),
+        format: iroh_blobs::BlobFormat::Raw,
+    }]);
+
+    let res = tags.rename("y", "z").await;
+    assert!(res.is_err());
     Ok(())
 }