Address review comments

Author: rklaehn

src/store/fs.rs

@@ -1333,7 +1333,7 @@ impl FsStore {
             .thread_name_fn(|| {
                 format!(
                     "iroh-blob-store-{}",
-                    THREAD_NR.fetch_add(1, Ordering::SeqCst)
+                    THREAD_NR.fetch_add(1, Ordering::Relaxed)
                 )
             })
             .enable_time()

src/store/fs/bao_file.rs

@@ -531,10 +531,6 @@ impl entity_manager::Reset for BaoFileHandle {
     fn reset(&mut self) {
         self.send_replace(BaoFileStorage::Initial);
     }
-
-    fn ref_count(&self) -> usize {
-        self.0.receiver_count() + self.0.sender_count()
-    }
 }
 
 /// A reader for a bao file, reading just the data.

src/store/fs/util/entity_manager.rs

@@ -12,12 +12,6 @@ use tokio::sync::{mpsc, oneshot};
 pub trait Reset: Default {
     /// Reset the state to its default value.
     fn reset(&mut self);
-
-    /// A ref count to ensure that the state is unique when shutting down.
-    ///
-    /// You are not allowed to clone the state out of a task, even though that
-    /// is possible.
-    fn ref_count(&self) -> usize;
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
@@ -219,7 +213,6 @@ mod entity_actor {
                 )
                 .await
                 .ok();
-            assert_eq!(self.state.state.ref_count(), 1);
             P::on_shutdown(self.state.clone(), ShutdownCause::Idle).await;
             // Notify the main actor that we have completed shutdown.
             // here we also give back the rest of ourselves so the main actor can recycle us.
@@ -846,10 +839,6 @@ mod tests {
             fn reset(&mut self) {
                 *self.0.borrow_mut() = Default::default();
             }
-
-            fn ref_count(&self) -> usize {
-                Arc::strong_count(&self.0)
-            }
         }
 
         #[derive(Debug, Default)]
@@ -971,8 +960,9 @@ mod tests {
                 for id in values.keys() {
                     let log = global.log.get(id).unwrap();
                     if log.len() % 2 != 0 {
-                        println!("{log:#?}");
-                        panic!("Log for entity {id} must contain an even number of events");
+                        panic!(
+                            "Log for entity {id} must contain an even number of events.\n{log:#?}"
+                        );
                     }
                     for (i, (event, _)) in log.iter().enumerate() {
                         assert_eq!(
@@ -1106,10 +1096,6 @@ mod tests {
             fn reset(&mut self) {
                 *self.0.borrow_mut() = Default::default();
             }
-
-            fn ref_count(&self) -> usize {
-                1
-            }
         }
 
         fn get_path(root: impl AsRef<Path>, id: u64) -> PathBuf {