fix off by one bug in the quick hacky valid_ranges

Author: rklaehn

src/downloader2.rs

@@ -510,7 +510,7 @@ mod tests {
     #![allow(clippy::single_range_in_vec_init)]
     use std::ops::Range;
 
-    use crate::net_protocol::Blobs;
+    use crate::{net_protocol::Blobs, store::MapMut};
 
     use super::*;
     use bao_tree::ChunkNum;
@@ -546,6 +546,16 @@ mod tests {
         SecretKey::from(secret).public()
     }
 
+    #[tokio::test]
+    async fn test_chunk_ranges() -> TestResult<()> {
+        let store = crate::store::mem::Store::new();
+        let tt = store.import_bytes(vec![0u8;1025].into(), crate::BlobFormat::Raw).await?;
+        let entry = store.get_mut(tt.hash()).await?.unwrap();
+        let valid = crate::get::db::valid_ranges::<crate::store::mem::Store>(&entry).await?;
+        println!("{valid:?}");
+        Ok(())
+    }
+
     #[test]
     fn test_planner_1() {
         let mut planner = StripePlanner2::new(0, 4);

src/get/db.rs

@@ -241,7 +241,7 @@ pub async fn valid_ranges<D: MapMut>(entry: &D::EntryMut) -> anyhow::Result<Chun
     // compute the valid range from just looking at the data file
     let mut data_reader = entry.data_reader().await?;
     let data_size = data_reader.size().await?;
-    let valid_from_data = ChunkRanges::from(..ChunkNum::full_chunks(data_size));
+    let valid_from_data = ChunkRanges::from(..ChunkNum::chunks(data_size));
     // compute the valid range from just looking at the outboard file
     let mut outboard = entry.outboard().await?;
     let all = ChunkRanges::all();