clippy

Author: rklaehn

src/api/downloader.rs

@@ -4,23 +4,20 @@ use std::{
     fmt::Debug,
     future::{Future, IntoFuture},
     io,
-    ops::Deref,
     sync::Arc,
-    time::{Duration, SystemTime},
 };
 
 use anyhow::bail;
 use genawaiter::sync::Gen;
-use iroh::{endpoint::Connection, Endpoint, NodeId};
+use iroh::{Endpoint, NodeId};
 use irpc::{channel::mpsc, rpc_requests};
 use n0_future::{future, stream, BufferedStreamExt, Stream, StreamExt};
 use rand::seq::SliceRandom;
 use serde::{de::Error, Deserialize, Serialize};
-use tokio::{sync::Mutex, task::JoinSet};
-use tokio_util::time::FutureExt;
-use tracing::{info, instrument::Instrument, warn};
+use tokio::task::JoinSet;
+use tracing::instrument::Instrument;
 
-use super::{remote::GetConnection, Store};
+use super::Store;
 use crate::{
     protocol::{GetManyRequest, GetRequest},
     util::{
@@ -445,7 +442,7 @@ async fn execute_get(
                 request: request.clone(),
             })
             .await?;
-        let mut conn = pool.connect(provider);
+        let conn = pool.connect(provider);
         let local = remote.local_for_request(request.clone()).await?;
         if local.is_complete() {
             return Ok(());

src/api/remote.rs

@@ -662,6 +662,8 @@ impl Remote {
     ) -> GetResult<Stats> {
         let store = self.store();
         let root = request.hash;
+        // I am cloning the connection, but it's fine because the original connection or ConnectionRef stays alive
+        // for the duration of the operation.
         let start = crate::get::fsm::start(conn.clone(), request, Default::default());
         let connected = start.next().await?;
         trace!("Getting header");

src/util/connection_pool.rs

@@ -19,7 +19,7 @@ use std::{
 };
 
 use iroh::{
-    endpoint::{ConnectError, Connection},
+    endpoint::ConnectError,
     Endpoint, NodeId,
 };
 use n0_future::{
@@ -111,8 +111,6 @@ pub enum ConnectionPoolError {
     Shutdown,
 }
 
-pub type PoolConnectResult = std::result::Result<Connection, PoolConnectError>;
-
 enum ActorMessage {
     RequestRef(RequestRef),
     ConnectionIdle { id: NodeId },