Bug: SqlString.id was not passing raw qualified identifiers

Also improved test coverage of branch in lib/SqlString.js.

Author: mikesamuel

lib/SqlString.js

@@ -14,7 +14,7 @@ var CHARS_ESCAPE_MAP    = {
   '\''   : '\\\'',
   '\\'   : '\\\\'
 };
-var ONE_ID_PATTERN = '^`(?:[^`]|``)+`$'; // TODO(mikesamuel): Should allow ``?
+var ONE_ID_PATTERN = '`(?:[^`]|``)+`'; // TODO(mikesamuel): Should allow ``?
 // One or more Identifiers separated by dots.
 var QUALIFIED_ID_REGEXP = new RegExp(
   '^' + ONE_ID_PATTERN + '(?:[.]' + ONE_ID_PATTERN + ')*$');

test/unit/test-SqlString.js

@@ -259,9 +259,18 @@ test('SqlString.format', {
 
   'double quest marks passes pre-escaped id': function () {
     var sql = SqlString.format(
-      'SELECT * FROM ?? WHERE id = ?',
-      [SqlString.identifier('table'), 42]);
-    assert.equal(sql, 'SELECT * FROM `table` WHERE id = 42');
+      'SELECT ?? FROM ?? WHERE id = ?',
+      [SqlString.identifier('table.id'),
+       SqlString.identifier('table'), 42]);
+    assert.equal(sql, 'SELECT `table`.`id` FROM `table` WHERE id = 42');
+  },
+
+  'double quest marks rejects invalid raw': function () {
+    assert.throws(function () {
+      SqlString.format(
+        'SELECT * FROM ?? WHERE id = 42',
+        [SqlString.raw('NOW()')]);
+    });
   },
 
   'extra question marks are left untouched': function() {