Fix escaping Date objects from foreign isolates

fixes #67

Author: dougwilson

HISTORY.md

@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Fix escaping `Date` objects from foreign isolates
+
 2.3.2 / 2020-04-15
 ==================
 

lib/SqlString.js

@@ -40,7 +40,7 @@ SqlString.escape = function escape(val, stringifyObjects, timeZone) {
     case 'boolean': return (val) ? 'true' : 'false';
     case 'number': return val + '';
     case 'object':
-      if (val instanceof Date) {
+      if (Object.prototype.toString.call(val) === '[object Date]') {
         return SqlString.dateToString(val, timeZone || 'local');
       } else if (Array.isArray(val)) {
         return SqlString.arrayToList(val, timeZone);

test/unit/test-SqlString.js

@@ -1,6 +1,7 @@
 var assert    = require('assert');
 var SqlString = require('../../');
 var test      = require('utest');
+var vm        = require('vm');
 
 test('SqlString.escapeId', {
   'value is quoted': function() {
@@ -222,6 +223,14 @@ test('SqlString.escape', {
     assert.strictEqual(string, 'NULL');
   },
 
+  'dates from other isolates are converted': function() {
+    var expected = '2012-05-07 11:42:03.002';
+    var date     = vm.runInNewContext('new Date(2012, 4, 7, 11, 42, 3, 2)');
+    var string   = SqlString.escape(date);
+
+    assert.strictEqual(string, "'" + expected + "'");
+  },
+
   'buffers are converted to hex': function() {
     var buffer = new Buffer([0, 1, 254, 255]);
     var string = SqlString.escape(buffer);