tests: add changeUser timeout test

Author: dougwilson

test/FakeServer.js

@@ -309,34 +309,36 @@ FakeConnection.prototype._parsePacket = function(header) {
       }
       break;
     case Packets.ComChangeUserPacket:
-      if (packet.user === 'does-not-exist') {
-        this._sendPacket(new Packets.ErrorPacket({
-          errno   : Errors.ER_ACCESS_DENIED_ERROR,
-          message : 'User does not exist'
-        }));
-        this._parser.resetPacketNumber();
-        break;
-      } else if (packet.database === 'does-not-exist') {
-        this._sendPacket(new Packets.ErrorPacket({
-          errno   : Errors.ER_BAD_DB_ERROR,
-          message : 'Database does not exist'
-        }));
+      if (!this.emit('changeUser', packet)) {
+        if (packet.user === 'does-not-exist') {
+          this._sendPacket(new Packets.ErrorPacket({
+            errno   : Errors.ER_ACCESS_DENIED_ERROR,
+            message : 'User does not exist'
+          }));
+          this._parser.resetPacketNumber();
+          break;
+        } else if (packet.database === 'does-not-exist') {
+          this._sendPacket(new Packets.ErrorPacket({
+            errno   : Errors.ER_BAD_DB_ERROR,
+            message : 'Database does not exist'
+          }));
+          this._parser.resetPacketNumber();
+          break;
+        }
+
+        this._clientAuthenticationPacket = new Packets.ClientAuthenticationPacket({
+          clientFlags   : this._clientAuthenticationPacket.clientFlags,
+          filler        : this._clientAuthenticationPacket.filler,
+          maxPacketSize : this._clientAuthenticationPacket.maxPacketSize,
+          protocol41    : this._clientAuthenticationPacket.protocol41,
+          charsetNumber : packet.charsetNumber,
+          database      : packet.database,
+          scrambleBuff  : packet.scrambleBuff,
+          user          : packet.user
+        });
+        this._sendPacket(new Packets.OkPacket());
         this._parser.resetPacketNumber();
-        break;
       }
-
-      this._clientAuthenticationPacket = new Packets.ClientAuthenticationPacket({
-        clientFlags   : this._clientAuthenticationPacket.clientFlags,
-        filler        : this._clientAuthenticationPacket.filler,
-        maxPacketSize : this._clientAuthenticationPacket.maxPacketSize,
-        protocol41    : this._clientAuthenticationPacket.protocol41,
-        charsetNumber : packet.charsetNumber,
-        database      : packet.database,
-        scrambleBuff  : packet.scrambleBuff,
-        user          : packet.user
-      });
-      this._sendPacket(new Packets.OkPacket());
-      this._parser.resetPacketNumber();
       break;
     case Packets.ComQuitPacket:
       if (!this.emit('quit', packet)) {

test/unit/connection/test-change-user-timeout.js

@@ -0,0 +1,38 @@
+var assert     = require('assert');
+var common     = require('../../common');
+var connection = common.createConnection({
+  port : common.fakeServerPort,
+  user : 'user_1'
+});
+
+var timeout = setTimeout(function () {
+  throw new Error('test timeout');
+}, 5000);
+
+var server = common.createFakeServer();
+
+server.listen(common.fakeServerPort, function (err) {
+  assert.ifError(err);
+
+  connection.query('SELECT CURRENT_USER()', function (err, result) {
+    assert.ifError(err);
+    assert.strictEqual(result[0]['CURRENT_USER()'], 'user_1@localhost');
+
+    connection.changeUser({user: 'user_2', timeout: 1000}, function (err) {
+      assert.ok(err);
+      assert.equal(err.code, 'PROTOCOL_SEQUENCE_TIMEOUT');
+      assert.equal(err.message, 'ChangeUser inactivity timeout');
+
+      connection.destroy();
+      server.destroy();
+      clearTimeout(timeout);
+    });
+  });
+});
+
+server.on('connection', function (conn) {
+  conn.handshake();
+  conn.on('changeUser', function () {
+    // do nothing
+  });
+});