tests: add ok helper method for unit tests

Author: dougwilson

test/FakeServer.js

@@ -100,9 +100,14 @@ FakeConnection.prototype.handshake = function(options) {
   this._sendPacket(this._handshakeInitializationPacket);
 };
 
+FakeConnection.prototype.ok = function ok() {
+  this._sendPacket(new Packets.OkPacket());
+  this._parser.resetPacketNumber();
+};
+
 FakeConnection.prototype._sendAuthResponse = function _sendAuthResponse(got, expected) {
   if (expected.toString('hex') === got.toString('hex')) {
-    this._sendPacket(new Packets.OkPacket());
+    this.ok();
   } else {
     this.deny('expected ' + expected.toString('hex') + ' got ' + got.toString('hex'));
   }
@@ -280,8 +285,7 @@ FakeConnection.prototype._parsePacket = function() {
       this.user     = (packet.user || null);
 
       if (!this.emit('clientAuthentication', packet)) {
-        this._sendPacket(new Packets.OkPacket());
-        this._parser.resetPacketNumber();
+        this.ok();
       }
       break;
     case Packets.SSLRequestPacket:
@@ -294,8 +298,7 @@ FakeConnection.prototype._parsePacket = function() {
       break;
     case Packets.ComPingPacket:
       if (!this.emit('ping', packet)) {
-        this._sendPacket(new Packets.OkPacket());
-        this._parser.resetPacketNumber();
+        this.ok();
       }
       break;
     case Packets.ComChangeUserPacket:
@@ -311,8 +314,7 @@ FakeConnection.prototype._parsePacket = function() {
           break;
         }
 
-        this._sendPacket(new Packets.OkPacket());
-        this._parser.resetPacketNumber();
+        this.ok();
       }
       break;
     case Packets.ComQuitPacket:

test/unit/connection/test-exception-safety.js

@@ -76,8 +76,7 @@ server.on('connection', function (conn) {
         this.error('Parse error', common.Errors.ER_PARSE_ERROR);
         break;
       case 'USE test':
-        this._sendPacket(new common.Packets.OkPacket());
-        this._parser.resetPacketNumber();
+        this.ok();
         break;
       default:
         this._handleQueryPacket(packet);

test/unit/connection/test-packet-out-of-order.js

@@ -10,8 +10,7 @@ server.listen(common.fakeServerPort, function(err) {
   connection.connect(function(err) {
     assert.ifError(err);
 
-    serverConn._sendPacket(new common.Packets.OkPacket());
-    serverConn._parser.resetPacketNumber();
+    serverConn.ok();
 
     connection.end(function(err) {
       assert.ok(err);

test/unit/connection/test-quit-ok-packet.js

@@ -16,7 +16,6 @@ server.listen(common.fakeServerPort, function (err) {
 server.on('connection', function (conn) {
   conn.handshake();
   conn.on('quit', function () {
-    conn._sendPacket(new common.Packets.OkPacket());
-    conn._parser.resetPacketNumber();
+    conn.ok();
   });
 });

test/unit/pool/test-acquire-timeout-existing.js

@@ -48,8 +48,7 @@ server.on('connection', function(incomingConnection) {
   });
   incomingConnection.on('ping', function() {
     if (!fail) {
-      this._sendPacket(new common.Packets.OkPacket());
-      this._parser.resetPacketNumber();
+      this.ok();
     }
 
     fail = false;

test/unit/pool/test-connection-bad.js

@@ -49,8 +49,7 @@ server.on('connection', function(incomingConnection) {
     if (fail) {
       setTimeout(this.destroy.bind(this), 100);
     } else {
-      this._sendPacket(new common.Packets.OkPacket());
-      this._parser.resetPacketNumber();
+      this.ok();
     }
 
     fail = false;

test/unit/pool/test-end-ping.js

@@ -33,8 +33,7 @@ server.on('connection', function (conn) {
   conn.handshake();
   conn.on('ping', function () {
     setTimeout(function () {
-      conn._sendPacket(new common.Packets.OkPacket());
-      conn._parser.resetPacketNumber();
+      conn.ok();
     }, 100);
   });
 });