refactor(rule): made rule optional

oniice · oniice · commit 1cd60b2f7ab4 · 2025-11-21T11:00:10.000Z
main rule should catch everything

Signed-off-by: Fred Myerscough &lt;oniice@gmail.com&gt;
diff --git a/README.md b/README.md
@@ -30,12 +30,12 @@ plugin "aws-meta" {
 
 |Name|Description|Severity|Enabled|Link|
 | --- | --- | --- | --- | --- |
-|aws_iam_role_policy_hardcoded_region|Validates that there are no hardcoded AWS regions in IAM role policy documents|WARNING|✔|[docs](docs/rules.md#aws_iam_role_policy_hardcoded_region)|
-|aws_iam_role_policy_hardcoded_partition|Validates that there are no hardcoded AWS partitions in IAM role policy documents|WARNING|✔|[docs](docs/rules.md#aws_iam_role_policy_hardcoded_partition)|
-|aws_iam_policy_hardcoded_region|Validates that there are no hardcoded AWS regions in IAM policy documents|WARNING|✔|[docs](docs/rules.md#aws_iam_policy_hardcoded_region)|
-|aws_iam_policy_hardcoded_partition|Validates that there are no hardcoded AWS partitions in IAM policy documents|WARNING|✔|[docs](docs/rules.md#aws_iam_policy_hardcoded_partition)|
-|aws_provider_hardcoded_region|Validates that there are no hardcoded AWS regions in provider configuration|WARNING|✔|[docs](docs/rules.md#aws_provider_hardcoded_region)|
-|aws_arn_hardcoded|Validates that there are no hardcoded AWS regions or partitions in ARN values across all resource types|WARNING|✔|[docs](docs/rules.md#aws_arn_hardcoded)|
+|aws_meta_hardcoded|Validates that there are no hardcoded AWS regions or partitions in ARN values across all resource types|WARNING|✔|[docs](docs/rules.md#aws_meta_hardcoded)|
+|aws_iam_role_policy_hardcoded_region|Validates that there are no hardcoded AWS regions in IAM role policy documents|WARNING||[docs](docs/rules.md#aws_iam_role_policy_hardcoded_region)|
+|aws_iam_role_policy_hardcoded_partition|Validates that there are no hardcoded AWS partitions in IAM role policy documents|WARNING||[docs](docs/rules.md#aws_iam_role_policy_hardcoded_partition)|
+|aws_iam_policy_hardcoded_region|Validates that there are no hardcoded AWS regions in IAM policy documents|WARNING||[docs](docs/rules.md#aws_iam_policy_hardcoded_region)|
+|aws_iam_policy_hardcoded_partition|Validates that there are no hardcoded AWS partitions in IAM policy documents|WARNING||[docs](docs/rules.md#aws_iam_policy_hardcoded_partition)|
+|aws_provider_hardcoded_region|Validates that there are no hardcoded AWS regions in provider configuration|WARNING||[docs](docs/rules.md#aws_provider_hardcoded_region)|
 
 For detailed examples and usage information, see the [Rule Details documentation](docs/rules.md).
 
diff --git a/rules/aws_iam_policy_hardcoded_partition.go b/rules/aws_iam_policy_hardcoded_partition.go
@@ -29,7 +29,7 @@ func (r *AwsIamPolicyHardcodedPartitionRule) Name() string {
 
 // Enabled returns whether the rule is enabled by default
 func (r *AwsIamPolicyHardcodedPartitionRule) Enabled() bool {
-	return true
+	return false
 }
 
 // Severity returns the rule severity
diff --git a/rules/aws_iam_policy_hardcoded_region.go b/rules/aws_iam_policy_hardcoded_region.go
@@ -29,7 +29,7 @@ func (r *AwsIamPolicyHardcodedRegionRule) Name() string {
 
 // Enabled returns whether the rule is enabled by default
 func (r *AwsIamPolicyHardcodedRegionRule) Enabled() bool {
-	return true
+	return false
 }
 
 // Severity returns the rule severity
diff --git a/rules/aws_iam_role_policy_hardcoded_partition.go b/rules/aws_iam_role_policy_hardcoded_partition.go
@@ -29,7 +29,7 @@ func (r *AwsIamRolePolicyHardcodedPartitionRule) Name() string {
 
 // Enabled returns whether the rule is enabled by default
 func (r *AwsIamRolePolicyHardcodedPartitionRule) Enabled() bool {
-	return true
+	return false
 }
 
 // Severity returns the rule severity
diff --git a/rules/aws_iam_role_policy_hardcoded_region.go b/rules/aws_iam_role_policy_hardcoded_region.go
@@ -29,7 +29,7 @@ func (r *AwsIamRolePolicyHardcodedRegionRule) Name() string {
 
 // Enabled returns whether the rule is enabled by default
 func (r *AwsIamRolePolicyHardcodedRegionRule) Enabled() bool {
-	return true
+	return false
 }
 
 // Severity returns the rule severity
diff --git a/rules/aws_provider_hardcoded_region.go b/rules/aws_provider_hardcoded_region.go
@@ -26,7 +26,7 @@ func (r *AwsProviderHardcodedRegionRule) Name() string {
 
 // Enabled returns whether the rule is enabled by default
 func (r *AwsProviderHardcodedRegionRule) Enabled() bool {
-	return true
+	return false
 }
 
 // Severity returns the rule severity

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func (r *AwsIamPolicyHardcodedPartitionRule) Name() string {`
`29`	`29`
`30`	`30`	`// Enabled returns whether the rule is enabled by default`
`31`	`31`	`func (r *AwsIamPolicyHardcodedPartitionRule) Enabled() bool {`
`32`		`- return true`
	`32`	`+ return false`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// Severity returns the rule severity`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func (r *AwsIamRolePolicyHardcodedPartitionRule) Name() string {`
`29`	`29`
`30`	`30`	`// Enabled returns whether the rule is enabled by default`
`31`	`31`	`func (r *AwsIamRolePolicyHardcodedPartitionRule) Enabled() bool {`
`32`		`- return true`
	`32`	`+ return false`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// Severity returns the rule severity`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func (r *AwsProviderHardcodedRegionRule) Name() string {`
`26`	`26`
`27`	`27`	`// Enabled returns whether the rule is enabled by default`
`28`	`28`	`func (r *AwsProviderHardcodedRegionRule) Enabled() bool {`
`29`		`- return true`
	`29`	`+ return false`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`// Severity returns the rule severity`