refactor(rule): changed the name to make more sense

Signed-off-by: Fred Myerscough <oniice@gmail.com>

Author: oniice

docs/rules.md

@@ -1,5 +1,46 @@
 # Rule Details
 
+## aws_meta_hardcoded
+
+This is a comprehensive rule that checks ALL AWS resources for hardcoded regions and partitions in ARN values. It works by walking through all expressions in your Terraform files and detecting any string that looks like an ARN with hardcoded values.
+
+This rule covers resource types including:
+- Lambda (permissions, event source mappings, functions)
+- SNS/SQS (subscriptions, queue policies)
+- CloudWatch (event targets, log subscriptions, alarms)
+- API Gateway (integrations, authorizers)
+- KMS (grants, aliases, keys)
+- Secrets Manager (rotations, policies)
+- ECS (services, task definitions)
+- RDS (instances, event subscriptions, clusters)
+- S3 (notifications, policies, access points)
+- And many more...
+
+**Example violations:**
+```hcl
+resource "aws_lambda_permission" "test" {
+  source_arn = "arn:aws:s3:us-east-1:123456789012:bucket/my-bucket"  # ❌ Hardcoded region and partition
+}
+
+resource "aws_kms_grant" "test" {
+  key_id = "arn:aws:kms:eu-west-1:123456789012:key/12345678-1234-1234-1234-123456789012"  # ❌ Hardcoded region and partition
+}
+```
+
+**Recommended fixes:**
+```hcl
+data "aws_region" "current" {}
+data "aws_partition" "current" {}
+
+resource "aws_lambda_permission" "test" {
+  source_arn = "arn:${data.aws_partition.current.partition}:s3:${data.aws_region.current.name}:123456789012:bucket/my-bucket"  # ✅ Dynamic
+}
+
+resource "aws_kms_grant" "test" {
+  key_id = "arn:${data.aws_partition.current.partition}:kms:${data.aws_region.current.name}:123456789012:key/12345678-1234-1234-1234-123456789012"  # ✅ Dynamic
+}
+```
+
 ## aws_iam_role_policy_hardcoded_region
 
 This rule checks `aws_iam_role_policy` resources for hardcoded AWS regions in policy documents. It examines both JSON policy strings and structured policy documents to detect:
@@ -151,43 +192,4 @@ provider "aws" {
 }
 ```
 
-## aws_arn_hardcoded
-
-This is a comprehensive rule that checks ALL AWS resources for hardcoded regions and partitions in ARN values. It works by walking through all expressions in your Terraform files and detecting any string that looks like an ARN with hardcoded values.
-
-This rule covers resource types including:
-- Lambda (permissions, event source mappings, functions)
-- SNS/SQS (subscriptions, queue policies)
-- CloudWatch (event targets, log subscriptions, alarms)
-- API Gateway (integrations, authorizers)
-- KMS (grants, aliases, keys)
-- Secrets Manager (rotations, policies)
-- ECS (services, task definitions)
-- RDS (instances, event subscriptions, clusters)
-- S3 (notifications, policies, access points)
-- And many more...
 
-**Example violations:**
-```hcl
-resource "aws_lambda_permission" "test" {
-  source_arn = "arn:aws:s3:us-east-1:123456789012:bucket/my-bucket"  # ❌ Hardcoded region and partition
-}
-
-resource "aws_kms_grant" "test" {
-  key_id = "arn:aws:kms:eu-west-1:123456789012:key/12345678-1234-1234-1234-123456789012"  # ❌ Hardcoded region and partition
-}
-```
-
-**Recommended fixes:**
-```hcl
-data "aws_region" "current" {}
-data "aws_partition" "current" {}
-
-resource "aws_lambda_permission" "test" {
-  source_arn = "arn:${data.aws_partition.current.partition}:s3:${data.aws_region.current.name}:123456789012:bucket/my-bucket"  # ✅ Dynamic
-}
-
-resource "aws_kms_grant" "test" {
-  key_id = "arn:${data.aws_partition.current.partition}:kms:${data.aws_region.current.name}:123456789012:key/12345678-1234-1234-1234-123456789012"  # ✅ Dynamic
-}
-```

examples/failing/.tflint.hcl

@@ -22,6 +22,6 @@ rule "aws_provider_hardcoded_region" {
   enabled = true
 }
 
-rule "aws_arn_hardcoded" {
+rule "aws_meta_hardcoded" {
   enabled = true
 }

examples/passing/.tflint.hcl

@@ -22,6 +22,6 @@ rule "aws_provider_hardcoded_region" {
   enabled = true
 }
 
-rule "aws_arn_hardcoded" {
+rule "aws_meta_hardcoded" {
   enabled = true
 }

main.go

@@ -12,12 +12,12 @@ func main() {
 			Name:    "aws-meta",
 			Version: "0.1.0",
 			Rules: []tflint.Rule{
+				rules.NewAwsMetaHardcodedRule(),
 				rules.NewAwsIamRolePolicyHardcodedRegionRule(),
 				rules.NewAwsIamRolePolicyHardcodedPartitionRule(),
 				rules.NewAwsIamPolicyHardcodedRegionRule(),
 				rules.NewAwsIamPolicyHardcodedPartitionRule(),
 				rules.NewAwsProviderHardcodedRegionRule(),
-				rules.NewAwsARNHardcodedRule(),
 			},
 		},
 	})

rules/aws_arn_hardcoded.go renamed to rules/aws_meta_hardcoded.go

@@ -9,39 +9,39 @@ import (
 	"github.com/terraform-linters/tflint-plugin-sdk/tflint"
 )
 
-// AwsARNHardcodedRule checks for hardcoded regions and partitions in ARN values
+// AwsMetaHardcodedRule checks for hardcoded regions and partitions in ARN values
 // across all AWS resources by walking all expressions
-type AwsARNHardcodedRule struct {
+type AwsMetaHardcodedRule struct {
 	tflint.DefaultRule
 }
 
-// NewAwsARNHardcodedRule returns a new rule
-func NewAwsARNHardcodedRule() *AwsARNHardcodedRule {
-	return &AwsARNHardcodedRule{}
+// NewAwsMetaHardcodedRule returns a new rule
+func NewAwsMetaHardcodedRule() *AwsMetaHardcodedRule {
+	return &AwsMetaHardcodedRule{}
 }
 
 // Name returns the rule name
-func (r *AwsARNHardcodedRule) Name() string {
-	return "aws_arn_hardcoded"
+func (r *AwsMetaHardcodedRule) Name() string {
+	return "aws_meta_hardcoded"
 }
 
 // Enabled returns whether the rule is enabled by default
-func (r *AwsARNHardcodedRule) Enabled() bool {
+func (r *AwsMetaHardcodedRule) Enabled() bool {
 	return true
 }
 
 // Severity returns the rule severity
-func (r *AwsARNHardcodedRule) Severity() tflint.Severity {
+func (r *AwsMetaHardcodedRule) Severity() tflint.Severity {
 	return tflint.WARNING
 }
 
 // Link returns the rule reference link
-func (r *AwsARNHardcodedRule) Link() string {
+func (r *AwsMetaHardcodedRule) Link() string {
 	return ""
 }
 
 // Check checks for hardcoded regions and partitions in ARN-like string values
-func (r *AwsARNHardcodedRule) Check(runner tflint.Runner) error {
+func (r *AwsMetaHardcodedRule) Check(runner tflint.Runner) error {
 	arnRegionPattern := awsmeta.GetARNRegionPattern()
 	arnPartitionPattern := awsmeta.GetPartitionPattern()
 

rules/aws_arn_hardcoded_test.go renamed to rules/aws_meta_hardcoded_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/terraform-linters/tflint-plugin-sdk/helper"
 )
 
-func Test_AwsARNHardcodedRule(t *testing.T) {
+func Test_AwsMetaHardcodedRule(t *testing.T) {
 	tests := []struct {
 		Name          string
 		Content       string
@@ -150,7 +150,7 @@ resource "aws_s3_bucket" "test" {
 		},
 	}
 
-	rule := NewAwsARNHardcodedRule()
+	rule := NewAwsMetaHardcodedRule()
 
 	for _, test := range tests {
 		t.Run(test.Name, func(t *testing.T) {