update N/Record definition to return type, remove getName method as not relevant

Author: simon-mycs

Tests/Utils/record.test.js

@@ -3,21 +3,21 @@
  *
  */
 
-const FileUnderTest = require('../../Utils/record');
+const Record = require('../../Utils/record');
 
 describe('testing record', () => {
   it('should return a function ', () => {
-    expect(FileUnderTest).toEqual(expect.any(Function));
+    expect(Record).toEqual(expect.any(Function));
   });
 });
 
 describe('setFieldValues', () => {
   it('should check whether method exists', () => {
-    const result = new FileUnderTest('');
+    const result = new Record('');
     expect(Object.prototype.hasOwnProperty.call(result, 'setFieldValues')).toBeTruthy();
   });
   it('should assign values to fieldName', () => {
-    const result = new FileUnderTest();
+    const result = new Record();
     const values = ['123456', '654321'];
     result.setFieldValues('selectField', values);
     expect(result.getFieldValue('selectField')).toEqual(['123456', '654321']);
@@ -26,7 +26,7 @@ describe('setFieldValues', () => {
 
 describe('getFieldValues', () => {
   it('should return values for id specified', () => {
-    const result = new FileUnderTest();
+    const result = new Record();
     result.setFieldValues('selectField', ['123', '123']);
     const myValues = result.getFieldValues('selectField');
     expect(myValues).toEqual(['123', '123']);
@@ -35,8 +35,9 @@ describe('getFieldValues', () => {
 
 describe('getRecordType', () => {
   it('should return record type', () => {
-    const result = new FileUnderTest();
+    const type = 'salesorder';
+    const result = new Record(type);
     const recordType = result.getRecordType();
-    expect(recordType).toEqual('nlobjRecord');
+    expect(recordType).toEqual(type);
   });
 });

Utils/record.js

@@ -5,21 +5,21 @@ const sublistObj = require('./sublistObjectMembers.jsx');
  *
  * @classDescription Record object
  * @constructor
- * @param {string} name
+ * @param {string} type
  * @param {object} defaultValues
  * @returns {nlobjRecord}
  */
-function NsRecord(name, defaultValues = {}) {
+function NsRecord(type, defaultValues = {}) {
   const id = defaultValues.id || Math.ceil(Math.random() * 100);
   const activeLine = {};
   this.values = defaultValues;
   this.values.item = this.values.item || [];
   this.values.links = this.values.links || [];
-  this.type = 'nlobjRecord';
+  this.type = type || 'nlobjRecord';
   return {
     // 1.0 methods
     getId: () => id,
-    getName: () => name,
+    getRecordType: () => this.type, // same method for both 1.0 and 2.0
 
     // 2.0 methods
     // eslint-disable-next-line no-unused-vars
@@ -47,7 +47,6 @@ function NsRecord(name, defaultValues = {}) {
     getLineItemCount: sublist => this.values[sublist].length,
     getLineItemText: (sublist, field, index) => this.values[sublist][index - 1][`${field}_display`],
     getLineItemValue: (sublist, field, index) => this.values[sublist][index - 1][field],
-    getRecordType: () => this.type,
     getSublistText: options => this.values[options.sublistId][options.line][options.fieldId],
     getSublistValue: options => this.values[options.sublistId][options.line][options.fieldId],
     getSublists: sublistObj,