move key property initialization in __wakeup in case an old version is unserialized

Author: drealecs

src/Enum.php

@@ -74,6 +74,13 @@ public function __construct($value)
         $this->value = $value;
     }
 
+    public function __wakeup()
+    {
+        if ($this->key === null) {
+            $this->key = static::search($this->value);
+        }
+    }
+
     /**
      * @param mixed $value
      * @return static
@@ -100,10 +107,11 @@ public function getValue()
      * Returns the enum key (i.e. the constant name).
      *
      * @psalm-pure
+     * @return string
      */
     public function getKey()
     {
-        return $this->key ?? ($this->key = static::search($this->value));
+        return $this->key;
     }
 
     /**

tests/EnumTest.php

@@ -330,7 +330,7 @@ public function testSerialize()
         $this->assertEquals($bin, bin2hex(serialize(EnumFixture::FOO())));
     }
 
-    public function testUnserialize()
+    public function testUnserializeVersionWithoutKey()
     {
         // split string for Pretty CI: "Line exceeds 120 characters"
         $bin = '4f3a33303a224d79434c6162735c54657374735c456e756d5c456e756d4669787'.
@@ -341,6 +341,22 @@ public function testUnserialize()
 
         $this->assertEquals(EnumFixture::FOO, $value->getValue());
         $this->assertTrue(EnumFixture::FOO()->equals($value));
+        $this->assertTrue(EnumFixture::FOO() == $value);
+    }
+
+    public function testUnserialize()
+    {
+        // split string for Pretty CI: "Line exceeds 120 characters"
+        $bin = '4f3a33303a224d79434c6162735c54657374735c456e756d5c456e756d4669787'.
+            '4757265223a323a7b733a383a22002a0076616c7565223b733a333a22666f6f223b73'.
+            '3a32323a22004d79434c6162735c456e756d5c456e756d006b6579223b733a333a22464f4f223b7d';
+
+        /* @var $value EnumFixture */
+        $value = unserialize(pack('H*', $bin));
+
+        $this->assertEquals(EnumFixture::FOO, $value->getValue());
+        $this->assertTrue(EnumFixture::FOO()->equals($value));
+        $this->assertTrue(EnumFixture::FOO() == $value);
     }
 
     /**