Skip to content

Commit 88057a7

Browse files
committed
fix: new arch codegen by unify NativeRNExternalDisplayEvent
1 parent 9c9350c commit 88057a7

File tree

5 files changed

+32
-12
lines changed

5 files changed

+32
-12
lines changed

packages/react-native-external-display/android/src/newarch/java/com/externaldisplay/RNExternalDisplayModule.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import android.content.Context;
44
import com.facebook.react.bridge.ReactApplicationContext;
55
import com.facebook.react.bridge.ReactMethod;
6+
import com.facebook.react.bridge.ReadableMap;
67
import com.facebook.react.bridge.WritableMap;
78
import com.facebook.react.bridge.Arguments;
89

@@ -37,4 +38,18 @@ public WritableMap getInitialScreens() {
3738

3839
@Override
3940
public void init() {}
41+
42+
// --- Mock methods (from iOS) ---
43+
44+
@Override
45+
public boolean requestScene(ReadableMap options) { return false; }
46+
47+
@Override
48+
public boolean closeScene(String sceneId) { return false; }
49+
50+
@Override
51+
public boolean isMainSceneActive() { return false; }
52+
53+
@Override
54+
public boolean resumeMainScene() { return false; }
4055
}

packages/react-native-external-display/android/src/oldarch/java/com/externaldisplay/RNExternalDisplayModule.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.facebook.react.bridge.ReactApplicationContext;
55
import com.facebook.react.bridge.ReactContextBaseJavaModule;
66
import com.facebook.react.bridge.ReactMethod;
7+
import com.facebook.react.bridge.ReadableMap;
78

89
import android.view.Display;
910
import android.hardware.display.DisplayManager;
@@ -33,4 +34,18 @@ public Map<String, Object> getConstants() {
3334
map.put("SCREEN_INFO", ExternalDisplayHelper.getScreenInfo(dm.getDisplays()));
3435
return map;
3536
}
37+
38+
// --- Mock methods (from iOS) ---
39+
40+
@Override
41+
public boolean requestScene(ReadableMap options) { return false; }
42+
43+
@Override
44+
public boolean closeScene(String sceneId) { return false; }
45+
46+
@Override
47+
public boolean isMainSceneActive() { return false; }
48+
49+
@Override
50+
public boolean resumeMainScene() { return false; }
3651
}

packages/react-native-external-display/js/NativeRNExternalDisplayEvent.android.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/react-native-external-display/js/NativeRNExternalDisplayEvent.ios.js renamed to packages/react-native-external-display/js/NativeRNExternalDisplayEvent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export interface Spec extends TurboModule {
66
getInitialScreens: () => {||},
77
init: () => void,
88

9-
// Scene API
9+
// Scene API (iOS only)
1010
requestScene: (options: {}) => boolean,
1111
closeScene: (sceneId: string) => boolean,
1212
isMainSceneActive: () => boolean,

packages/react-native-external-display/js/SceneManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import RNExternalDisplayEvent from './NativeRNExternalDisplayEvent.android'
1+
import RNExternalDisplayEvent from './NativeRNExternalDisplayEvent'
22

33
const sceneTypes = {
44
EXTERNAL_DISPLAY: '@RNExternalDisplay_externalDisplay',

0 commit comments

Comments
 (0)