Merge pull request #985 from hazendaz/tests

[cleanup] More cleanup

Author: hazendaz

src/main/java/org/mybatis/spring/SqlSessionFactoryBean.java

@@ -555,11 +555,10 @@ private <T> T[] appendArrays(T[] oldArrays, T[] newArrays, IntFunction<T[]> gene
     }
     if (newArrays == null) {
       return oldArrays;
-    } else {
-      List<T> newList = new ArrayList<>(Arrays.asList(oldArrays));
-      newList.addAll(Arrays.asList(newArrays));
-      return newList.toArray(generator.apply(0));
     }
+    List<T> newList = new ArrayList<>(Arrays.asList(oldArrays));
+    newList.addAll(Arrays.asList(newArrays));
+    return newList.toArray(generator.apply(0));
   }
 
   @Override

src/main/java/org/mybatis/spring/annotation/MapperScannerRegistrar.java

@@ -61,6 +61,7 @@
  */
 public class MapperScannerRegistrar implements ImportBeanDefinitionRegistrar, ResourceLoaderAware {
 
+  // Note: Do not move resourceLoader via cleanup
   private ResourceLoader resourceLoader;
 
   @Override

src/main/java/org/mybatis/spring/mapper/MapperScannerConfigurer.java

@@ -468,11 +468,11 @@ private String getPropertyValue(String propertyName, PropertyValues values) {
     }
     if (value instanceof String) {
       return value.toString();
-    } else if (value instanceof TypedStringValue) {
+    }
+    if (value instanceof TypedStringValue) {
       return ((TypedStringValue) value).getValue();
-    } else {
-      return null;
     }
+    return null;
   }
 
   @SuppressWarnings("unchecked")