Code smell reduction

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/exception/DuplicateTableAliasException.java

@@ -32,18 +32,13 @@
  */
 public class DuplicateTableAliasException extends RuntimeException {
 
-    private final SqlTable table;
-    private final String newAlias;
-    private final String existingAlias;
-
     public DuplicateTableAliasException(SqlTable table, String newAlias, String existingAlias) {
-        this.table = Objects.requireNonNull(table);
-        this.newAlias = Objects.requireNonNull(newAlias);
-        this.existingAlias = Objects.requireNonNull(existingAlias);
+        super(generateMessage(Objects.requireNonNull(table),
+                Objects.requireNonNull(newAlias),
+                Objects.requireNonNull(existingAlias)));
     }
 
-    @Override
-    public String getMessage() {
+    private static String generateMessage(SqlTable table, String newAlias, String existingAlias) {
         return "Table \"" + table.tableNameAtRuntime() //$NON-NLS-1$
                 + "\" with requested alias \"" + newAlias //$NON-NLS-1$
                 + "\" is already aliased in this query with alias \"" + existingAlias //$NON-NLS-1$

src/test/java/examples/joins/JoinMapperTest.java

@@ -44,6 +44,8 @@
 import org.junit.jupiter.api.Test;
 import org.mybatis.dynamic.sql.exception.DuplicateTableAliasException;
 import org.mybatis.dynamic.sql.render.RenderingStrategies;
+import org.mybatis.dynamic.sql.select.QueryExpressionDSL;
+import org.mybatis.dynamic.sql.select.SelectModel;
 import org.mybatis.dynamic.sql.select.render.SelectStatementProvider;
 import org.mybatis.dynamic.sql.util.mybatis3.CommonSelectMapper;
 
@@ -948,14 +950,11 @@ void testSelf() {
 
     @Test
     void testSelfWithDuplicateAlias() {
-        assertThatExceptionOfType(DuplicateTableAliasException.class).isThrownBy(() ->
-                select(user.userId, user.userName, user.parentId)
-                        .from(user, "u1")
-                        .join(user, "u2").on(user.userId, equalTo(user.parentId))
-                        .where(user.userId, isEqualTo(4))
-                        .build()
-                        .render(RenderingStrategies.MYBATIS3)
-        ).withMessage("Table \"User\" with requested alias \"u2\" is already aliased in this query with alias \"u1\". Attempting to re-alias a table in the same query is not supported.");
+        QueryExpressionDSL<SelectModel> dsl = select(user.userId, user.userName, user.parentId)
+                .from(user, "u1");
+
+        assertThatExceptionOfType(DuplicateTableAliasException.class).isThrownBy(() -> dsl.join(user, "u2"))
+                .withMessage("Table \"User\" with requested alias \"u2\" is already aliased in this query with alias \"u1\". Attempting to re-alias a table in the same query is not supported.");
     }
 
     @Test