Coverage

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/select/HavingDSL.java

@@ -20,14 +20,10 @@
 import org.mybatis.dynamic.sql.util.Buildable;
 
 public class HavingDSL extends AbstractHavingStarter<HavingDSL.StandaloneHavingFinisher> {
-    private StandaloneHavingFinisher havingFinisher;
+    private final StandaloneHavingFinisher havingFinisher = new StandaloneHavingFinisher();
 
     @Override
     protected StandaloneHavingFinisher having() {
-        if (havingFinisher == null) {
-            havingFinisher = new StandaloneHavingFinisher();
-        }
-
         return havingFinisher;
     }
 

src/test/java/org/mybatis/dynamic/sql/select/HavingModelTest.java

@@ -0,0 +1,58 @@
+/*
+ *    Copyright 2016-2023 the original author or authors.
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *       https://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+package org.mybatis.dynamic.sql.select;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mybatis.dynamic.sql.SqlBuilder.*;
+
+import java.sql.JDBCType;
+import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.junit.jupiter.api.Test;
+import org.mybatis.dynamic.sql.SqlColumn;
+import org.mybatis.dynamic.sql.SqlTable;
+import org.mybatis.dynamic.sql.render.RenderingStrategies;
+import org.mybatis.dynamic.sql.render.TableAliasCalculator;
+import org.mybatis.dynamic.sql.select.render.HavingRenderer;
+import org.mybatis.dynamic.sql.util.FragmentAndParameters;
+
+class HavingModelTest {
+    @Test
+    void testNormalHaving() {
+        SqlTable table = SqlTable.of("foo");
+        SqlColumn<Integer> id = table.column("id", JDBCType.INTEGER);
+
+        HavingModel model = having(id, isLessThan(4))
+                .or(id, isGreaterThan(14))
+                .build();
+
+        Optional<FragmentAndParameters> havingClause = renderHavingModel(model);
+
+        assertThat(havingClause).hasValueSatisfying(hc ->
+                assertThat(hc.fragment()).isEqualTo("having id < :p1 or id > :p2")
+        );
+    }
+
+    private Optional<FragmentAndParameters> renderHavingModel(HavingModel havingModel) {
+        return HavingRenderer.withHavingModel(havingModel)
+                .withRenderingStrategy(RenderingStrategies.SPRING_NAMED_PARAMETER)
+                .withSequence(new AtomicInteger(1))
+                .withTableAliasCalculator(TableAliasCalculator.empty())
+                .build()
+                .render();
+    }
+}