Merge pull request #3362 from hazendaz/pom-cleanup

tests: Use final and add constructor where needed

Author: hazendaz

src/test/java/org/apache/ibatis/builder/XmlConfigBuilderTest.java

@@ -333,7 +333,7 @@ void propertiesSpecifyResourceAndUrlAtSameTime() {
         "The properties element cannot specify both a URL and a resource based property file reference.  Please specify one or the other.");
   }
 
-  static class MySqlProvider {
+  static final class MySqlProvider {
     @SuppressWarnings("unused")
     public static String provideSql() {
       return "SELECT 1";

src/test/java/org/apache/ibatis/databases/blog/StoredProcedures.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2009-2023 the original author or authors.
+ *    Copyright 2009-2024 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-public class StoredProcedures {
+public final class StoredProcedures {
   public static void selectTwoSetsOfTwoAuthors(int p1, int p2, ResultSet[] rs1, ResultSet[] rs2) throws SQLException {
     try (Connection conn = DriverManager.getConnection("jdbc:default:connection")) {
       PreparedStatement ps1 = conn.prepareStatement("select * from author where id in (?,?)");

src/test/java/org/apache/ibatis/executor/ExecutorTestHelper.java

@@ -53,7 +53,7 @@
 import org.apache.ibatis.type.JdbcType;
 import org.apache.ibatis.type.TypeHandlerRegistry;
 
-class ExecutorTestHelper {
+final class ExecutorTestHelper {
 
   static final Cache authorCache;
 

src/test/java/org/apache/ibatis/plugin/PluginTest.java

@@ -60,7 +60,7 @@ void shouldPluginSwitchSchema() {
     }
   }
 
-  static class SchemaHolder {
+  static final class SchemaHolder {
     private static ThreadLocal<String> value = ThreadLocal.withInitial(() -> "PUBLIC");
 
     public static void set(String tenantName) {
@@ -70,6 +70,9 @@ public static void set(String tenantName) {
     public static String get() {
       return value.get();
     }
+
+    private SchemaHolder() {
+    }
   }
 
   @Intercepts(@Signature(type = StatementHandler.class, method = "prepare", args = { Connection.class, Integer.class }))

src/test/java/org/apache/ibatis/submitted/constructor_automapping/Author.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2009-2023 the original author or authors.
+ *    Copyright 2009-2024 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -15,7 +15,7 @@
  */
 package org.apache.ibatis.submitted.constructor_automapping;
 
-public class Author {
+public final class Author {
 
   private final Integer id;
   private String name;

src/test/java/org/apache/ibatis/submitted/dirty_select/Mapper.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2009-2023 the original author or authors.
+ *    Copyright 2009-2024 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -44,7 +44,7 @@ public interface Mapper {
   @Insert("insert into users (name) values (#{name}) returning id, name")
   int insert(User user);
 
-  static class MyProvider {
+  static final class MyProvider {
     public static String getSql() {
       return "insert into users (name) values (#{name}) returning id, name";
     }

src/test/java/org/apache/ibatis/submitted/discriminator/Contract.java

@@ -16,8 +16,8 @@
 package org.apache.ibatis.submitted.discriminator;
 
 public class Contract {
-  private Integer id;
-  private Owner owner;
+  private final Integer id;
+  private final Owner owner;
 
   public Contract(Integer id, Owner owner) {
     this.id = id;

src/test/java/org/apache/ibatis/submitted/dynsql/CustomUtil.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2009-2023 the original author or authors.
+ *    Copyright 2009-2024 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -15,7 +15,7 @@
  */
 package org.apache.ibatis.submitted.dynsql;
 
-public class CustomUtil {
+public final class CustomUtil {
   public static String esc(final String s) {
     return s.replace("'", "''");
   }

src/test/java/org/apache/ibatis/submitted/enum_with_method/Mood.java

@@ -29,7 +29,7 @@ public String getMessage() {
     }
   };
 
-  private int value;
+  private final int value;
 
   Mood(int value) {
     this.value = value;

src/test/java/org/apache/ibatis/submitted/global_variables_defaults/SupportClasses.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2009-2023 the original author or authors.
+ *    Copyright 2009-2024 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -54,7 +54,7 @@ public void setName(String name) {
     }
   }
 
-  static class Utils {
+  static final class Utils {
     static SupportClasses.CustomCache unwrap(Cache cache) {
       Field field;
       try {