Skip to content

Commit 7447a86

Browse files
committed
fix(test): correct member vs non-member function calls in test_shm.cpp
- Fix handle class member functions: remove incorrect shm:: prefix - h.acquire() not h.shm::acquire() - h.release() not h.shm::release() - h.sub_ref() not h.shm::sub_ref() - Keep shm:: prefix for namespace-level global functions: - shm::acquire(), shm::release(id), shm::get_mem() - shm::remove(), shm::get_ref(id), shm::sub_ref(id) - Fix comments to use correct terminology - Resolves: 'shm::acquire is not a class member' compilation errors
1 parent 7092df5 commit 7447a86

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/test_shm.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class ShmTest : public ::testing::Test {
3737

3838
// ========== Low-level API Tests ==========
3939

40-
// Test acquire with shm::create mode
40+
// Test acquire with create mode
4141
TEST_F(ShmTest, AcquireCreate) {
4242
std::string name = generate_unique_name("acquire_create");
4343
const std::size_t size = 1024;
@@ -54,7 +54,7 @@ TEST_F(ShmTest, AcquireCreate) {
5454
shm::remove(id);
5555
}
5656

57-
// Test acquire with shm::open mode (should fail if not exists)
57+
// Test acquire with open mode (should fail if not exists)
5858
TEST_F(ShmTest, AcquireOpenNonExistent) {
5959
std::string name = generate_unique_name("acquire_open_fail");
6060

@@ -65,7 +65,7 @@ TEST_F(ShmTest, AcquireOpenNonExistent) {
6565
}
6666
}
6767

68-
// Test acquire with both shm::create and shm::open modes
68+
// Test acquire with both create and open modes
6969
TEST_F(ShmTest, AcquireCreateOrOpen) {
7070
std::string name = generate_unique_name("acquire_both");
7171
const std::size_t size = 2048;
@@ -312,40 +312,40 @@ TEST_F(ShmTest, HandleRef) {
312312
EXPECT_GT(ref, 0);
313313
}
314314

315-
// Test handle shm::sub_ref() method
315+
// Test handle sub_ref() method
316316
TEST_F(ShmTest, HandleSubRef) {
317317
std::string name = generate_unique_name("handle_sub_ref");
318318

319319
shm::handle h(name.c_str(), 256);
320320

321321
std::int32_t ref_before = h.ref();
322-
h.shm::sub_ref();
322+
h.sub_ref();
323323
std::int32_t ref_after = h.ref();
324324

325325
EXPECT_EQ(ref_after, ref_before - 1);
326326
}
327327

328-
// Test handle shm::acquire() method
328+
// Test handle acquire() method
329329
TEST_F(ShmTest, HandleAcquire) {
330330
shm::handle h;
331331
EXPECT_FALSE(h.valid());
332332

333333
std::string name = generate_unique_name("handle_acquire");
334-
bool result = h.shm::acquire(name.c_str(), 512);
334+
bool result = h.acquire(name.c_str(), 512);
335335

336336
EXPECT_TRUE(result);
337337
EXPECT_TRUE(h.valid());
338338
EXPECT_GE(h.size(), 512u);
339339
}
340340

341-
// Test handle shm::release() method
341+
// Test handle release() method
342342
TEST_F(ShmTest, HandleRelease) {
343343
std::string name = generate_unique_name("handle_release");
344344

345345
shm::handle h(name.c_str(), 256);
346346
ASSERT_TRUE(h.valid());
347347

348-
std::int32_t ref_count = h.shm::release();
348+
std::int32_t ref_count = h.release();
349349
EXPECT_GE(ref_count, 0);
350350
}
351351

@@ -407,7 +407,7 @@ TEST_F(ShmTest, HandleDetachAttach) {
407407
EXPECT_TRUE(h2.valid());
408408

409409
// Clean up
410-
h2.shm::release();
410+
h2.release();
411411
shm::remove(id);
412412
}
413413

0 commit comments

Comments
 (0)