Pass CStringName by ref

tederis · tederis · commit 8a36b95936d9 · 2025-09-24T13:51:26.000+07:00
diff --git a/Client/mods/deathmatch/logic/CClientEntity.cpp b/Client/mods/deathmatch/logic/CClientEntity.cpp
@@ -279,7 +279,7 @@ void CClientEntity::SetID(ElementID ID)
     }
 }
 
-CLuaArgument* CClientEntity::GetCustomData(CStringName name, bool bInheritData, bool* pbIsSynced)
+CLuaArgument* CClientEntity::GetCustomData(const CStringName& name, bool bInheritData, bool* pbIsSynced)
 {
     assert(name);
 
@@ -315,7 +315,7 @@ CLuaArguments* CClientEntity::GetAllCustomData(CLuaArguments* table)
     return table;
 }
 
-bool CClientEntity::GetCustomDataString(CStringName name, SString& strOut, bool bInheritData)
+bool CClientEntity::GetCustomDataString(const CStringName& name, SString& strOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -350,7 +350,7 @@ bool CClientEntity::GetCustomDataString(CStringName name, SString& strOut, bool
     return false;
 }
 
-bool CClientEntity::GetCustomDataInt(CStringName name, int& iOut, bool bInheritData)
+bool CClientEntity::GetCustomDataInt(const CStringName& name, int& iOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -388,7 +388,7 @@ bool CClientEntity::GetCustomDataInt(CStringName name, int& iOut, bool bInheritD
     return false;
 }
 
-bool CClientEntity::GetCustomDataFloat(CStringName name, float& fOut, bool bInheritData)
+bool CClientEntity::GetCustomDataFloat(const CStringName& name, float& fOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -415,7 +415,7 @@ bool CClientEntity::GetCustomDataFloat(CStringName name, float& fOut, bool bInhe
     return false;
 }
 
-bool CClientEntity::GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData)
+bool CClientEntity::GetCustomDataBool(const CStringName& name, bool& bOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -470,7 +470,7 @@ bool CClientEntity::GetCustomDataBool(CStringName name, bool& bOut, bool bInheri
     return false;
 }
 
-void CClientEntity::SetCustomData(CStringName name, const CLuaArgument& Variable, bool bSynchronized)
+void CClientEntity::SetCustomData(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized)
 {
     assert(name);
     if (name->length() > MAX_CUSTOMDATA_NAME_LENGTH)
@@ -499,7 +499,7 @@ void CClientEntity::SetCustomData(CStringName name, const CLuaArgument& Variable
     CallEvent("onClientElementDataChange", Arguments, true);
 }
 
-void CClientEntity::DeleteCustomData(CStringName name)
+void CClientEntity::DeleteCustomData(const CStringName& name)
 {
     // Grab the old variable
     SCustomData* pData = m_pCustomData->Get(name);
diff --git a/Client/mods/deathmatch/logic/CClientEntity.h b/Client/mods/deathmatch/logic/CClientEntity.h
@@ -202,14 +202,14 @@ class CClientEntity : public CClientEntityBase
     void      SetID(ElementID ID);
 
     CCustomData*   GetCustomDataPointer() { return m_pCustomData; }
-    CLuaArgument*  GetCustomData(CStringName name, bool bInheritData, bool* pbIsSynced = nullptr);
+    CLuaArgument*  GetCustomData(const CStringName& name, bool bInheritData, bool* pbIsSynced = nullptr);
     CLuaArguments* GetAllCustomData(CLuaArguments* table);
-    bool           GetCustomDataString(CStringName name, SString& strOut, bool bInheritData);
-    bool           GetCustomDataFloat(CStringName name, float& fOut, bool bInheritData);
-    bool           GetCustomDataInt(CStringName name, int& iOut, bool bInheritData);
-    bool           GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData);
-    void           SetCustomData(CStringName name, const CLuaArgument& Variable, bool bSynchronized = true);
-    void           DeleteCustomData(CStringName name);
+    bool           GetCustomDataString(const CStringName& name, SString& strOut, bool bInheritData);
+    bool           GetCustomDataFloat(const CStringName& name, float& fOut, bool bInheritData);
+    bool           GetCustomDataInt(const CStringName& name, int& iOut, bool bInheritData);
+    bool           GetCustomDataBool(const CStringName& name, bool& bOut, bool bInheritData);
+    void           SetCustomData(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized = true);
+    void           DeleteCustomData(const CStringName& name);
 
     virtual bool GetMatrix(CMatrix& matrix) const;
     virtual bool SetMatrix(const CMatrix& matrix);
diff --git a/Client/mods/deathmatch/logic/CCustomData.cpp b/Client/mods/deathmatch/logic/CCustomData.cpp
@@ -21,7 +21,7 @@ void CCustomData::Copy(CCustomData* pCustomData)
     }
 }
 
-SCustomData* CCustomData::Get(CStringName name)
+SCustomData* CCustomData::Get(const CStringName& name)
 {
     assert(name);
 
@@ -32,7 +32,7 @@ SCustomData* CCustomData::Get(CStringName name)
     return NULL;
 }
 
-void CCustomData::Set(CStringName name, const CLuaArgument& Variable, bool bSynchronized)
+void CCustomData::Set(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized)
 {
     assert(name);
 
@@ -54,7 +54,7 @@ void CCustomData::Set(CStringName name, const CLuaArgument& Variable, bool bSync
     }
 }
 
-bool CCustomData::Delete(CStringName name)
+bool CCustomData::Delete(const CStringName& name)
 {
     // Find the item and delete it
     auto it = m_Data.find(name);
diff --git a/Client/mods/deathmatch/logic/CCustomData.h b/Client/mods/deathmatch/logic/CCustomData.h
@@ -26,10 +26,10 @@ class CCustomData
 public:
     void Copy(CCustomData* pCustomData);
 
-    SCustomData* Get(CStringName name);
-    void         Set(CStringName name, const CLuaArgument& Variable, bool bSynchronized = true);
+    SCustomData* Get(const CStringName& name);
+    void         Set(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized = true);
 
-    bool Delete(CStringName name);
+    bool Delete(const CStringName& name);
 
     std::unordered_map<CStringName, SCustomData>::const_iterator IterBegin() { return m_Data.begin(); }
     std::unordered_map<CStringName, SCustomData>::const_iterator IterEnd() { return m_Data.end(); }
diff --git a/Client/mods/deathmatch/logic/lua/CLuaArgument.cpp b/Client/mods/deathmatch/logic/lua/CLuaArgument.cpp
@@ -334,7 +334,7 @@ void CLuaArgument::ReadString(const std::string_view& string)
     m_strString = std::string{string};
 }
 
-void CLuaArgument::ReadString(CStringName string)
+void CLuaArgument::ReadString(const CStringName& string)
 {
     m_iType = LUA_TSTRING;
     DeleteTableData();
diff --git a/Client/mods/deathmatch/logic/lua/CLuaArgument.h b/Client/mods/deathmatch/logic/lua/CLuaArgument.h
@@ -43,7 +43,7 @@ class CLuaArgument
     void ReadNumber(double dNumber);
     void ReadString(const std::string& string);
     void ReadString(const std::string_view& string);
-    void ReadString(CStringName string);
+    void ReadString(const CStringName& string);
     void ReadString(const char* string);
     void ReadElement(CClientEntity* pElement);
     void ReadScriptID(uint uiScriptID);
diff --git a/Client/mods/deathmatch/logic/lua/CLuaArguments.cpp b/Client/mods/deathmatch/logic/lua/CLuaArguments.cpp
@@ -351,7 +351,7 @@ CLuaArgument* CLuaArguments::PushString(const std::string_view& string)
     return arg;
 }
 
-CLuaArgument* CLuaArguments::PushString(CStringName string)
+CLuaArgument* CLuaArguments::PushString(const CStringName& string)
 {
     CLuaArgument* arg = new CLuaArgument();
     arg->ReadString(string);
diff --git a/Client/mods/deathmatch/logic/lua/CLuaArguments.h b/Client/mods/deathmatch/logic/lua/CLuaArguments.h
@@ -57,7 +57,7 @@ class CLuaArguments
     CLuaArgument* PushNumber(double dNumber);
     CLuaArgument* PushString(const std::string& string);
     CLuaArgument* PushString(const std::string_view& string);
-    CLuaArgument* PushString(CStringName string);
+    CLuaArgument* PushString(const CStringName& string);
     CLuaArgument* PushString(const char* string);
     CLuaArgument* PushElement(CClientEntity* pElement);
     CLuaArgument* PushArgument(const CLuaArgument& argument);
diff --git a/Server/mods/deathmatch/logic/CCustomData.cpp b/Server/mods/deathmatch/logic/CCustomData.cpp
@@ -21,7 +21,7 @@ void CCustomData::Copy(CCustomData* pCustomData)
     }
 }
 
-SCustomData* CCustomData::Get(CStringName name) const
+SCustomData* CCustomData::Get(const CStringName& name) const
 {
     assert(name);
 
@@ -32,7 +32,7 @@ SCustomData* CCustomData::Get(CStringName name) const
     return NULL;
 }
 
-SCustomData* CCustomData::GetSynced(CStringName name)
+SCustomData* CCustomData::GetSynced(const CStringName& name)
 {
     assert(name);
 
@@ -43,7 +43,7 @@ SCustomData* CCustomData::GetSynced(CStringName name)
     return NULL;
 }
 
-bool CCustomData::DeleteSynced(CStringName name)
+bool CCustomData::DeleteSynced(const CStringName& name)
 {
     // Find the item and delete it
     auto iter = m_SyncedData.find(name);
@@ -57,7 +57,7 @@ bool CCustomData::DeleteSynced(CStringName name)
     return false;
 }
 
-void CCustomData::UpdateSynced(CStringName name, const CLuaArgument& Variable, ESyncType syncType)
+void CCustomData::UpdateSynced(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType)
 {
     if (syncType == ESyncType::BROADCAST)
     {
@@ -81,7 +81,7 @@ void CCustomData::UpdateSynced(CStringName name, const CLuaArgument& Variable, E
     }
 }
 
-void CCustomData::Set(CStringName name, const CLuaArgument& Variable, ESyncType syncType)
+void CCustomData::Set(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType)
 {
     assert(name);
 
@@ -106,7 +106,7 @@ void CCustomData::Set(CStringName name, const CLuaArgument& Variable, ESyncType
     }
 }
 
-bool CCustomData::Delete(CStringName name)
+bool CCustomData::Delete(const CStringName& name)
 {
     // Find the item and delete it
     auto it = m_Data.find(name);
@@ -121,7 +121,7 @@ bool CCustomData::Delete(CStringName name)
     return false;
 }
 
-void CCustomData::SetClientChangesMode(CStringName name, eCustomDataClientTrust mode)
+void CCustomData::SetClientChangesMode(const CStringName& name, eCustomDataClientTrust mode)
 {
     SCustomData& pData = m_Data[name];
     pData.clientChangesMode = mode;
diff --git a/Server/mods/deathmatch/logic/CCustomData.h b/Server/mods/deathmatch/logic/CCustomData.h
@@ -44,13 +44,13 @@ class CCustomData
 public:
     void Copy(CCustomData* pCustomData);
 
-    SCustomData* Get(CStringName name) const;
-    SCustomData* GetSynced(CStringName name);
-    void         Set(CStringName name, const CLuaArgument& Variable, ESyncType syncType = ESyncType::BROADCAST);
+    SCustomData* Get(const CStringName& name) const;
+    SCustomData* GetSynced(const CStringName& name);
+    void         Set(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType = ESyncType::BROADCAST);
 
-    bool Delete(CStringName name);
+    bool Delete(const CStringName& name);
 
-    void SetClientChangesMode(CStringName name, eCustomDataClientTrust mode);
+    void SetClientChangesMode(const CStringName& name, eCustomDataClientTrust mode);
 
     unsigned short CountOnlySynchronized();
 
@@ -63,8 +63,8 @@ class CCustomData
     std::unordered_map<CStringName, SCustomData>::const_iterator SyncedIterEnd() { return m_SyncedData.end(); }
 
 private:
-    bool DeleteSynced(CStringName name);
-    void UpdateSynced(CStringName name, const CLuaArgument& Variable, ESyncType syncType);
+    bool DeleteSynced(const CStringName& name);
+    void UpdateSynced(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType);
 
     std::unordered_map<CStringName, SCustomData> m_Data;
     std::unordered_map<CStringName, SCustomData> m_SyncedData;
diff --git a/Server/mods/deathmatch/logic/CElement.cpp b/Server/mods/deathmatch/logic/CElement.cpp
@@ -508,7 +508,7 @@ void CElement::ReadCustomData(CEvents* pEvents, CXMLNode& Node)
     }
 }
 
-CLuaArgument* CElement::GetCustomData(CStringName name, bool bInheritData, ESyncType* pSyncType, eCustomDataClientTrust* clientChangesMode)
+CLuaArgument* CElement::GetCustomData(const CStringName& name, bool bInheritData, ESyncType* pSyncType, eCustomDataClientTrust* clientChangesMode)
 {
     assert(name);
 
@@ -550,7 +550,7 @@ CLuaArguments* CElement::GetAllCustomData(CLuaArguments* table)
     return table;
 }
 
-bool CElement::GetCustomDataString(CStringName name, char* pOut, size_t sizeBuffer, bool bInheritData)
+bool CElement::GetCustomDataString(const CStringName& name, char* pOut, size_t sizeBuffer, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -589,7 +589,7 @@ bool CElement::GetCustomDataString(CStringName name, char* pOut, size_t sizeBuff
     return false;
 }
 
-bool CElement::GetCustomDataInt(CStringName name, int& iOut, bool bInheritData)
+bool CElement::GetCustomDataInt(const CStringName& name, int& iOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -627,7 +627,7 @@ bool CElement::GetCustomDataInt(CStringName name, int& iOut, bool bInheritData)
     return false;
 }
 
-bool CElement::GetCustomDataFloat(CStringName name, float& fOut, bool bInheritData)
+bool CElement::GetCustomDataFloat(const CStringName& name, float& fOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -654,7 +654,7 @@ bool CElement::GetCustomDataFloat(CStringName name, float& fOut, bool bInheritDa
     return false;
 }
 
-bool CElement::GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData)
+bool CElement::GetCustomDataBool(const CStringName& name, bool& bOut, bool bInheritData)
 {
     // Grab the custom data variable
     CLuaArgument* pData = GetCustomData(name, bInheritData);
@@ -709,7 +709,7 @@ bool CElement::GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData
     return false;
 }
 
-void CElement::SetCustomData(CStringName name, const CLuaArgument& Variable, ESyncType syncType, CPlayer* pClient, bool bTriggerEvent)
+void CElement::SetCustomData(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType, CPlayer* pClient, bool bTriggerEvent)
 {
     assert(name);
     if (name->length() > MAX_CUSTOMDATA_NAME_LENGTH)
@@ -741,7 +741,7 @@ void CElement::SetCustomData(CStringName name, const CLuaArgument& Variable, ESy
     }
 }
 
-void CElement::DeleteCustomData(CStringName name)
+void CElement::DeleteCustomData(const CStringName& name)
 {
     // Grab the old variable
     SCustomData* pData = m_CustomData.Get(name);
diff --git a/Server/mods/deathmatch/logic/CElement.h b/Server/mods/deathmatch/logic/CElement.h
@@ -139,15 +139,15 @@ class CElement
 
     void           ReadCustomData(CEvents* pEvents, CXMLNode& Node);
     CCustomData&   GetCustomDataManager() { return m_CustomData; }
-    CLuaArgument*  GetCustomData(CStringName name, bool bInheritData, ESyncType* pSyncType = nullptr, eCustomDataClientTrust* clientChangesMode = nullptr);
+    CLuaArgument*  GetCustomData(const CStringName& name, bool bInheritData, ESyncType* pSyncType = nullptr, eCustomDataClientTrust* clientChangesMode = nullptr);
     CLuaArguments* GetAllCustomData(CLuaArguments* table);
-    bool           GetCustomDataString(CStringName name, char* pOut, size_t sizeBuffer, bool bInheritData);
-    bool           GetCustomDataInt(CStringName name, int& iOut, bool bInheritData);
-    bool           GetCustomDataFloat(CStringName name, float& fOut, bool bInheritData);
-    bool           GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData);
-    void           SetCustomData(CStringName name, const CLuaArgument& Variable, ESyncType syncType = ESyncType::BROADCAST, CPlayer* pClient = NULL,
+    bool           GetCustomDataString(const CStringName& name, char* pOut, size_t sizeBuffer, bool bInheritData);
+    bool           GetCustomDataInt(const CStringName& name, int& iOut, bool bInheritData);
+    bool           GetCustomDataFloat(const CStringName& name, float& fOut, bool bInheritData);
+    bool           GetCustomDataBool(const CStringName& name, bool& bOut, bool bInheritData);
+    void           SetCustomData(const CStringName& name, const CLuaArgument& Variable, ESyncType syncType = ESyncType::BROADCAST, CPlayer* pClient = NULL,
                                  bool bTriggerEvent = true);
-    void           DeleteCustomData(CStringName name);
+    void           DeleteCustomData(const CStringName& name);
     void           SendAllCustomData(CPlayer* pPlayer);
 
     CXMLNode* OutputToXML(CXMLNode* pNode);
diff --git a/Server/mods/deathmatch/logic/lua/CLuaArgument.cpp b/Server/mods/deathmatch/logic/lua/CLuaArgument.cpp
@@ -339,7 +339,7 @@ void CLuaArgument::ReadString(const std::string_view& string)
     m_strString = string;
 }
 
-void CLuaArgument::ReadString(CStringName string)
+void CLuaArgument::ReadString(const CStringName& string)
 {
     m_iType = LUA_TSTRING;
     DeleteTableData();
diff --git a/Server/mods/deathmatch/logic/lua/CLuaArgument.h b/Server/mods/deathmatch/logic/lua/CLuaArgument.h
@@ -45,7 +45,7 @@ class CLuaArgument
     void ReadNumber(double dNumber);
     void ReadString(const std::string& string);
     void ReadString(const std::string_view& string);
-    void ReadString(CStringName string);
+    void ReadString(const CStringName& string);
     void ReadString(const char* string);
     void ReadElement(CElement* pElement);
     void ReadElementID(ElementID ID);
diff --git a/Server/mods/deathmatch/logic/lua/CLuaArguments.cpp b/Server/mods/deathmatch/logic/lua/CLuaArguments.cpp
@@ -372,7 +372,7 @@ CLuaArgument* CLuaArguments::PushString(const std::string_view& string)
     return arg;
 }
 
-CLuaArgument* CLuaArguments::PushString(CStringName string)
+CLuaArgument* CLuaArguments::PushString(const CStringName& string)
 {
     CLuaArgument* arg = new CLuaArgument();
     arg->ReadString(string);
diff --git a/Server/mods/deathmatch/logic/lua/CLuaArguments.h b/Server/mods/deathmatch/logic/lua/CLuaArguments.h
@@ -69,7 +69,7 @@ class CLuaArguments
     CLuaArgument* PushNumber(double dNumber);
     CLuaArgument* PushString(const std::string& string);
     CLuaArgument* PushString(const std::string_view& string);
-    CLuaArgument* PushString(CStringName string);
+    CLuaArgument* PushString(const CStringName& string);
     CLuaArgument* PushString(const char* string);
     CLuaArgument* PushElement(CElement* pElement);
     CLuaArgument* PushBan(CBan* pBan);

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ void CClientEntity::SetID(ElementID ID)`
`279`	`279`	`}`
`280`	`280`	`}`
`281`	`281`
`282`		`-CLuaArgument* CClientEntity::GetCustomData(CStringName name, bool bInheritData, bool* pbIsSynced)`
	`282`	`+CLuaArgument* CClientEntity::GetCustomData(const CStringName& name, bool bInheritData, bool* pbIsSynced)`
`283`	`283`	`{`
`284`	`284`	`assert(name);`
`285`	`285`
`@@ -315,7 +315,7 @@ CLuaArguments* CClientEntity::GetAllCustomData(CLuaArguments* table)`
`315`	`315`	`return table;`
`316`	`316`	`}`
`317`	`317`
`318`		`-bool CClientEntity::GetCustomDataString(CStringName name, SString& strOut, bool bInheritData)`
	`318`	`+bool CClientEntity::GetCustomDataString(const CStringName& name, SString& strOut, bool bInheritData)`
`319`	`319`	`{`
`320`	`320`	`// Grab the custom data variable`
`321`	`321`	`CLuaArgument* pData = GetCustomData(name, bInheritData);`
`@@ -350,7 +350,7 @@ bool CClientEntity::GetCustomDataString(CStringName name, SString& strOut, bool`
`350`	`350`	`return false;`
`351`	`351`	`}`
`352`	`352`
`353`		`-bool CClientEntity::GetCustomDataInt(CStringName name, int& iOut, bool bInheritData)`
	`353`	`+bool CClientEntity::GetCustomDataInt(const CStringName& name, int& iOut, bool bInheritData)`
`354`	`354`	`{`
`355`	`355`	`// Grab the custom data variable`
`356`	`356`	`CLuaArgument* pData = GetCustomData(name, bInheritData);`
`@@ -388,7 +388,7 @@ bool CClientEntity::GetCustomDataInt(CStringName name, int& iOut, bool bInheritD`
`388`	`388`	`return false;`
`389`	`389`	`}`
`390`	`390`
`391`		`-bool CClientEntity::GetCustomDataFloat(CStringName name, float& fOut, bool bInheritData)`
	`391`	`+bool CClientEntity::GetCustomDataFloat(const CStringName& name, float& fOut, bool bInheritData)`
`392`	`392`	`{`
`393`	`393`	`// Grab the custom data variable`
`394`	`394`	`CLuaArgument* pData = GetCustomData(name, bInheritData);`
`@@ -415,7 +415,7 @@ bool CClientEntity::GetCustomDataFloat(CStringName name, float& fOut, bool bInhe`
`415`	`415`	`return false;`
`416`	`416`	`}`
`417`	`417`
`418`		`-bool CClientEntity::GetCustomDataBool(CStringName name, bool& bOut, bool bInheritData)`
	`418`	`+bool CClientEntity::GetCustomDataBool(const CStringName& name, bool& bOut, bool bInheritData)`
`419`	`419`	`{`
`420`	`420`	`// Grab the custom data variable`
`421`	`421`	`CLuaArgument* pData = GetCustomData(name, bInheritData);`
`@@ -470,7 +470,7 @@ bool CClientEntity::GetCustomDataBool(CStringName name, bool& bOut, bool bInheri`
`470`	`470`	`return false;`
`471`	`471`	`}`
`472`	`472`
`473`		`-void CClientEntity::SetCustomData(CStringName name, const CLuaArgument& Variable, bool bSynchronized)`
	`473`	`+void CClientEntity::SetCustomData(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized)`
`474`	`474`	`{`
`475`	`475`	`assert(name);`
`476`	`476`	`if (name->length() > MAX_CUSTOMDATA_NAME_LENGTH)`
`@@ -499,7 +499,7 @@ void CClientEntity::SetCustomData(CStringName name, const CLuaArgument& Variable`
`499`	`499`	`CallEvent("onClientElementDataChange", Arguments, true);`
`500`	`500`	`}`
`501`	`501`
`502`		`-void CClientEntity::DeleteCustomData(CStringName name)`
	`502`	`+void CClientEntity::DeleteCustomData(const CStringName& name)`
`503`	`503`	`{`
`504`	`504`	`// Grab the old variable`
`505`	`505`	`SCustomData* pData = m_pCustomData->Get(name);`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ void CCustomData::Copy(CCustomData* pCustomData)`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-SCustomData* CCustomData::Get(CStringName name)`
	`24`	`+SCustomData* CCustomData::Get(const CStringName& name)`
`25`	`25`	`{`
`26`	`26`	`assert(name);`
`27`	`27`
`@@ -32,7 +32,7 @@ SCustomData* CCustomData::Get(CStringName name)`
`32`	`32`	`return NULL;`
`33`	`33`	`}`
`34`	`34`
`35`		`-void CCustomData::Set(CStringName name, const CLuaArgument& Variable, bool bSynchronized)`
	`35`	`+void CCustomData::Set(const CStringName& name, const CLuaArgument& Variable, bool bSynchronized)`
`36`	`36`	`{`
`37`	`37`	`assert(name);`
`38`	`38`
`@@ -54,7 +54,7 @@ void CCustomData::Set(CStringName name, const CLuaArgument& Variable, bool bSync`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`
`57`		`-bool CCustomData::Delete(CStringName name)`
	`57`	`+bool CCustomData::Delete(const CStringName& name)`
`58`	`58`	`{`
`59`	`59`	`// Find the item and delete it`
`60`	`60`	`auto it = m_Data.find(name);`
Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ void CLuaArgument::ReadString(const std::string_view& string)`
`334`	`334`	`m_strString = std::string{string};`
`335`	`335`	`}`
`336`	`336`
`337`		`-void CLuaArgument::ReadString(CStringName string)`
	`337`	`+void CLuaArgument::ReadString(const CStringName& string)`
`338`	`338`	`{`
`339`	`339`	`m_iType = LUA_TSTRING;`
`340`	`340`	`DeleteTableData();`
Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ CLuaArgument* CLuaArguments::PushString(const std::string_view& string)`
`351`	`351`	`return arg;`
`352`	`352`	`}`
`353`	`353`
`354`		`-CLuaArgument* CLuaArguments::PushString(CStringName string)`
	`354`	`+CLuaArgument* CLuaArguments::PushString(const CStringName& string)`
`355`	`355`	`{`
`356`	`356`	`CLuaArgument* arg = new CLuaArgument();`
`357`	`357`	`arg->ReadString(string);`