Fix showCursor not updating controls state when cursor already visible (#1034) (#4448)

MohabCodeX · web-flow · commit 117f804cb2aa · 2025-09-23T21:06:07.000+02:00
* Improve cursor visibility handling in CResource::ShowCursor function
diff --git a/Client/mods/deathmatch/logic/CResource.cpp b/Client/mods/deathmatch/logic/CResource.cpp
@@ -410,11 +410,11 @@ void CResource::ShowCursor(bool bShow, bool bToggleControls)
 
         // Update our showing cursor state
         m_bShowingCursor = bShow;
-
-        // Show cursor if more than 0 resources wanting the cursor on
-        g_pCore->ForceCursorVisible(m_iShowingCursor > 0, bToggleControls);
-        g_pClientGame->SetCursorEventsEnabled(m_iShowingCursor > 0);
     }
+
+    // Always update cursor and controls state regardless of cursor visibility change
+    g_pCore->ForceCursorVisible(m_iShowingCursor > 0, bToggleControls);
+    g_pClientGame->SetCursorEventsEnabled(m_iShowingCursor > 0);
 }
 
 SString CResource::GetResourceDirectoryPath(eAccessType accessType, const SString& strMetaPath)

Original file line number	Diff line number	Diff line change
`@@ -410,11 +410,11 @@ void CResource::ShowCursor(bool bShow, bool bToggleControls)`
`410`	`410`
`411`	`411`	`// Update our showing cursor state`
`412`	`412`	`m_bShowingCursor = bShow;`
`413`		`-`
`414`		`- // Show cursor if more than 0 resources wanting the cursor on`
`415`		`- g_pCore->ForceCursorVisible(m_iShowingCursor > 0, bToggleControls);`
`416`		`- g_pClientGame->SetCursorEventsEnabled(m_iShowingCursor > 0);`
`417`	`413`	`}`
	`414`	`+`
	`415`	`+ // Always update cursor and controls state regardless of cursor visibility change`
	`416`	`+ g_pCore->ForceCursorVisible(m_iShowingCursor > 0, bToggleControls);`
	`417`	`+ g_pClientGame->SetCursorEventsEnabled(m_iShowingCursor > 0);`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`SString CResource::GetResourceDirectoryPath(eAccessType accessType, const SString& strMetaPath)`