Early initialize CStaticFunctionDefinitions to avoid crashes when something calls into it early.

This fixes a popular crash where LunaSVG called into OutputChatBox before core and other pointers were valid

Author: Dutchman101

Client/mods/deathmatch/logic/CClientGame.cpp

@@ -82,6 +82,8 @@ CClientGame::CClientGame(bool bLocalPlay) : m_ServerInfo(new CServerInfo())
     // Init the global var with ourself
     g_pClientGame = this;
 
+    CStaticFunctionDefinitions::PreInitialize(g_pCore, g_pGame, this, &m_Events);
+
     // Packet handler
     m_pPacketHandler = new CPacketHandler();
 

Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

@@ -104,6 +104,14 @@ CStaticFunctionDefinitions::~CStaticFunctionDefinitions()
 {
 }
 
+void CStaticFunctionDefinitions::PreInitialize(CCoreInterface* pCore, CGame* pGame, CClientGame* pClientGame, CEvents* pEvents)
+{
+    m_pCore = pCore;
+    m_pGame = pGame;
+    m_pClientGame = pClientGame;
+    m_pEvents = pEvents;
+}
+
 bool CStaticFunctionDefinitions::AddEvent(CLuaMain& LuaMain, const char* szName, bool bAllowRemoteTrigger)
 {
     assert(szName);
@@ -263,23 +271,27 @@ bool CStaticFunctionDefinitions::ClearChatBox()
 
 bool CStaticFunctionDefinitions::OutputChatBox(const char* szText, unsigned char ucRed, unsigned char ucGreen, unsigned char ucBlue, bool bColorCoded)
 {
-    if (!szText || szText[0] == '\0')
+    // Early null-safety checks to prevent crashes when called before initialization
+    if (!m_pCore || !g_pClientGame || !szText || szText[0] == '\0')
         return false;
 
+    // Calculate length without color codes when bColorCoded is true for accurate visible text length
     SString textToProcess = bColorCoded ? RemoveColorCodes(szText) : SStringX(szText);
 
-    if (textToProcess.length() > MAX_OUTPUTCHATBOX_LENGTH) {
+    // Reject messages that exceed the maximum length
+    if (textToProcess.length() > MAX_OUTPUTCHATBOX_LENGTH)
         return false;
-    }
 
+    // Fire the onClientChatMessage event
     CLuaArguments Arguments;
     Arguments.PushString(szText);
     Arguments.PushNumber(ucRed);
     Arguments.PushNumber(ucGreen);
     Arguments.PushNumber(ucBlue);
 
     bool bCancelled = !g_pClientGame->GetRootEntity()->CallEvent("onClientChatMessage", Arguments, false);
-    if (!bCancelled) {
+    if (!bCancelled)
+    {
         m_pCore->ChatPrintfColor("%s", bColorCoded, ucRed, ucGreen, ucBlue, szText);
         return true;
     }

Client/mods/deathmatch/logic/CStaticFunctionDefinitions.h

@@ -27,6 +27,8 @@ class CStaticFunctionDefinitions
                                CClientManager* pManager);
     ~CStaticFunctionDefinitions();
 
+    static void PreInitialize(CCoreInterface* pCore, CGame* pGame, CClientGame* pClientGame, CEvents* pEvents);
+
     static bool AddEvent(CLuaMain& LuaMain, const char* szName, bool bAllowRemoteTrigger);
     static bool AddEventHandler(CLuaMain& LuaMain, const char* szName, CClientEntity& Entity, const CLuaFunctionRef& iLuaFunction, bool bPropagated,
                                 EEventPriorityType eventPriority, float fPriorityMod);