Skip to content

Commit c6d18c5

Browse files
authored
New build image (#37)
Use new image from `ghcr.io/muhamadto/spring-native-amazonlinux2-base:17-amazonlinux2` instead of `ghcr.io/muhamadto/spring-native-amazonlinux2-base-java17:latest`
1 parent 7b33b93 commit c6d18c5

File tree

13 files changed

+32
-46
lines changed

13 files changed

+32
-46
lines changed

.dockerignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@ README.md
1515
# there is no need to copy it again if you want to use your own setting file, you can comment the
1616
# line below
1717
settings-spring.xml
18+
19+
spring-native-aws-lambda-infra
20+
docker-compose.yml

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ jobs:
2424
release:
2525
runs-on: ubuntu-latest
2626
container:
27-
image: ghcr.io/muhamadto/spring-native-amazonlinux2-base-java17:latest
28-
options: --user=ci:automation
27+
image: ghcr.io/muhamadto/spring-native-amazonlinux2-base:17-amazonlinux2
28+
options: --user=worker:ci
2929
permissions:
3030
id-token: write
3131
contents: read

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
FROM ghcr.io/muhamadto/spring-native-amazonlinux2-base-java17:latest AS spring-native-aws-lambda-builder-java17
1+
FROM ghcr.io/muhamadto/spring-native-amazonlinux2-base:17-amazonlinux2
22

3-
COPY --chown=${USER_NAME}:${GROUP_NAME} . /opt/build
3+
COPY --chown=worker:ci . /home/worker/
44

55
RUN ./mvnw -ntp -Pnative package -DskipTests --file spring-native-aws-lambda-function/pom.xml

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,12 @@ and the following trust relationship
232232
"SNS:Subscribe",
233233
"SNS:GetTopicAttributes",
234234
"SNS:ListSubscriptionsByTopic",
235-
"SNS:Unsubscribe"
235+
"SNS:Unsubscribe",
236+
"SNS:TagResource",
237+
"SNS:UntagResource"
236238
],
237239
"Resource": [
238-
"arn:aws:sns:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-topic.fifo",
240+
"arn:aws:sns:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-topic",
239241
"arn:aws:sns:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-failure-topic"
240242
]
241243
},
@@ -252,9 +254,9 @@ and the following trust relationship
252254
],
253255
"Resource": [
254256
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-failure-queue-dlq",
255-
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-queue-dlq.fifo",
257+
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-queue-dlq",
256258
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-failure-queue",
257-
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-queue.fifo"
259+
"arn:aws:sqs:{aws-region}:{aws-account-number}:spring-native-aws-lambda-function-success-queue"
258260
]
259261
},
260262
{

cdk.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"app": "mvn exec:java -pl spring-native-aws-lambda-cdk -Dexec.mainClass=com.coffeebeans.cdk.Application"
2+
"app": "mvn exec:java -pl spring-native-aws-lambda-infra -Dexec.mainClass=com.coffeebeans.springnativeawslambda.infra.Application"
33
}

docker-compose.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
version: '3.9'
22
services:
33
spring-native-aws-lambda-function:
4-
image: ghcr.io/muhamadto/spring-native-amazonlinux2-base-java17:latest
4+
image: ghcr.io/muhamadto/spring-native-amazonlinux2-base:17-amazonlinux2
55
ports:
66
- 8080:8080
77
networks:
@@ -40,17 +40,6 @@ services:
4040
depends_on:
4141
- localstack
4242

43-
spring-native-aws-lambda-function-infrastructure:
44-
image: ghcr.io/muhamadto/spring-native-amazonlinux2-base-java17:latest
45-
environment:
46-
AWS_ACCESS_KEY_ID: local
47-
AWS_SECRET_ACCESS_KEY: local
48-
AWS_DEFAULT_REGION: ap-southeast-2
49-
entrypoint:
50-
- bash
51-
- -c
52-
53-
5443
localstack:
5544
image: localstack/localstack:latest
5645
logging:

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
</dependency>
9090
<dependency>
9191
<groupId>com.coffeebeans</groupId>
92-
<artifactId>spring-native-aws-lambda-cdk</artifactId>
92+
<artifactId>spring-native-aws-lambda-infra</artifactId>
9393
<version>${project.version}</version>
9494
</dependency>
9595
<!-- SPRING-NATIVE-AWS-LAMBDA ENDS -->

spring-native-aws-lambda-infra/src/main/java/com/coffeebeans/springnativeawslambda/infra/SpringNativeAwsLambdaStack.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ public SpringNativeAwsLambdaStack(@NotNull final Construct scope,
5555
@NotNull final StackProps props) {
5656
super(scope, id, props);
5757

58-
final Queue successQueue = createFifoQueue(SQS_SUCCESS_QUEUE_ID, true, MESSAGE_GROUP);
58+
final Queue successQueue = createQueue(SQS_SUCCESS_QUEUE_ID);
5959
final SqsSubscription successQueueSubscription = createSqsSubscription(successQueue);
60-
final Topic successTopic = createFifoTopic(SNS_SUCCESS_TOPIC_ID, true, true);
60+
final Topic successTopic = createTopic(SNS_SUCCESS_TOPIC_ID);
6161
successTopic.addSubscription(successQueueSubscription);
6262

6363
final Queue failureQueue = createQueue(SQS_FAILURE_QUEUE_ID);

spring-native-aws-lambda-infra/src/test/java/com/coffeebeans/springnativeawslambda/infra/ApiBaseStackTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ void should_create_and_return_lambda_function() {
173173

174174
final Function actual = this.apiBaseStack.createFunction(vpc,
175175
"test-function",
176-
"com.coffeebeans.cdk.lambda.CustomRuntime2Function::handleRequest",
176+
"com.coffeebeans.springnativeawslambda.infra.lambda.CustomRuntime2Function::handleRequest",
177177
Code.fromAsset(this.lambdaCodePath.toString()),
178178
fromTopicArn(this.apiBaseStack, "success-topic", "arn:aws:sns:us-east-1:***:success-topic"),
179179
fromTopicArn(this.apiBaseStack, "failure-topic", "arn:aws:sns:us-east-1:***:failure-topic"),
@@ -201,7 +201,7 @@ void should_create_and_return_lambda_rest_api() {
201201

202202
final Function function = this.apiBaseStack.createFunction(vpc,
203203
"test-function",
204-
"com.coffeebeans.cdk.lambda.CustomRuntime2Function::handleRequest",
204+
"com.coffeebeans.springnativeawslambda.infra.lambda.CustomRuntime2Function::handleRequest",
205205
Code.fromAsset(this.lambdaCodePath.toString()),
206206
fromTopicArn(this.apiBaseStack, "success-topic", "arn:aws:sns:us-east-1:***:success-topic"),
207207
fromTopicArn(this.apiBaseStack, "failure-topic", "arn:aws:sns:us-east-1:***:failure-topic"),

spring-native-aws-lambda-infra/src/test/java/com/coffeebeans/springnativeawslambda/infra/LambdaTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void should_have_default_policy_to_allow_lambda_publish_to_sns() {
139139
.reference(stringLikeRegexp("springnativeawslambdafunctionrole(.*)"))
140140
.build();
141141

142-
final PolicyStatement successSNSPublishPolicyStatement = getAllowSnsPublishPolicyStatement("springnativeawslambdafunctionsuccesstopicfifo(.*)");
142+
final PolicyStatement successSNSPublishPolicyStatement = getAllowSnsPublishPolicyStatement("springnativeawslambdafunctionsuccesstopic(.*)");
143143

144144
final PolicyStatement failureSNSPublishPolicyStatement = getAllowSnsPublishPolicyStatement("springnativeawslambdafunctionfailuretopic(.*)");
145145

@@ -166,7 +166,7 @@ void should_have_default_policy_to_allow_lambda_publish_to_sns() {
166166
void should_have_event_invoke_config_for_success_and_failure() {
167167

168168
final LambdaDestinationReference onFailure = createDestinationReference("springnativeawslambdafunctionfailuretopic(.*)");
169-
final LambdaDestinationReference onSuccess = createDestinationReference("springnativeawslambdafunctionsuccesstopicfifo(.*)");
169+
final LambdaDestinationReference onSuccess = createDestinationReference("springnativeawslambdafunctionsuccesstopic(.*)");
170170

171171
final LambdaEventInvokeConfigProperties lambdaEventInvokeConfigProperties = LambdaEventInvokeConfigProperties.builder()
172172
.functionName(ResourceReference.builder().reference(stringLikeRegexp("springnativeawslambdafunction(.*)")).build())

0 commit comments

Comments
 (0)