fix

Author: CosmoV

fastapi_jsonapi/querystring.py

@@ -242,6 +242,9 @@ def fields(self) -> Dict[str, List[str]]:
             self._get_schema(resource_type)
 
             for field_name in field_names:
+                if field_name == "":
+                    continue
+
                 if field_name not in schema.__fields__:
                     msg = "{schema} has no attribute {field}".format(
                         schema=schema.__name__,

tests/fixtures/app.py

@@ -112,7 +112,7 @@ def add_routers(app_plain: FastAPI):
         class_detail=DetailViewBaseGeneric,
         class_list=ListViewBaseGeneric,
         schema=PostCommentSchema,
-        resource_type="comment",
+        resource_type="post_comment",
         model=PostComment,
     )
 

tests/test_api/test_api_sqla_with_includes.py

@@ -232,7 +232,7 @@ async def test_select_custom_fields_with_includes(
                 ("fields[user]", "name"),
                 ("fields[post]", "title"),
                 # empty str means ignore all fields
-                ("fields[comment]", ""),
+                ("fields[post_comment]", ""),
                 ("include", "posts,posts.comments"),
                 ("sort", "id"),
             ],
@@ -284,7 +284,14 @@ async def test_select_custom_fields_with_includes(
                         "attributes": PostAttributesBaseSchema.from_orm(user_2_post).dict(include={"title"}),
                         "id": str(user_2_post.id),
                         "relationships": {
-                            "comments": {"data": [{"id": str(user_1_comment.id), "type": "post_comment"}]},
+                            "comments": {
+                                "data": [
+                                    {
+                                        "id": str(user_1_comment.id),
+                                        "type": "post_comment",
+                                    },
+                                ],
+                            },
                         },
                         "type": "post",
                     },
@@ -298,12 +305,12 @@ async def test_select_custom_fields_with_includes(
                     },
                     {
                         "attributes": {},
-                        "id": "1",
+                        "id": str(user_1_comment.id),
                         "type": "post_comment",
                     },
                     {
                         "attributes": {},
-                        "id": "2",
+                        "id": str(user_2_comment.id),
                         "type": "post_comment",
                     },
                 ],
@@ -426,7 +433,7 @@ async def test_create_comments_for_post(
         user_2: User,
         user_1_post: Post,
     ):
-        url = app.url_path_for("get_comment_list")
+        url = app.url_path_for("get_post_comment_list")
         url = f"{url}?include=author,post,post.user"
         comment_attributes = PostCommentAttributesBaseSchema(
             text=fake.sentence(),
@@ -457,7 +464,7 @@ async def test_create_comments_for_post(
         comment_id = comment_data.pop("id")
         assert comment_id
         assert comment_data == {
-            "type": "comment",
+            "type": "post_comment",
             "attributes": comment_attributes,
             "relationships": {
                 "post": {
@@ -515,7 +522,7 @@ async def test_create_comment_error_no_relationship(
         :param user_1_post:
         :return:
         """
-        url = app.url_path_for("get_comment_list")
+        url = app.url_path_for("get_post_comment_list")
         comment_attributes = PostCommentAttributesBaseSchema(
             text=fake.sentence(),
         ).dict()
@@ -556,7 +563,7 @@ async def test_create_comment_error_no_relationships_content(
         app: FastAPI,
         client: AsyncClient,
     ):
-        url = app.url_path_for("get_comment_list")
+        url = app.url_path_for("get_post_comment_list")
         comment_attributes = PostCommentAttributesBaseSchema(
             text=fake.sentence(),
         ).dict()
@@ -602,7 +609,7 @@ async def test_create_comment_error_no_relationships_field(
         app: FastAPI,
         client: AsyncClient,
     ):
-        url = app.url_path_for("get_comment_list")
+        url = app.url_path_for("get_post_comment_list")
         comment_attributes = PostCommentAttributesBaseSchema(
             text=fake.sentence(),
         ).dict()