Skip to content

WebGLRenderer: Clean up setupRenderBufferStorage #32456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrdoob merged 2 commits into from
Dec 2, 2025
Merged

WebGLRenderer: Clean up setupRenderBufferStorage #32456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8c2570
WebGLRenderer: Simplify setupRenderBufferStorage multisampling logic.
mrdoob Dec 2, 2025
807e25d
Clean up.
mrdoob Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/renderers/webgl/WebGLTextures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,7 +1575,7 @@ function WebGLTextures( _gl, extensions, state, properties, capabilities, utils,
}

// Setup storage for internal depth/stencil buffers and bind to correct framebuffer
function setupRenderBufferStorage( renderbuffer, renderTarget, isMultisample ) {
function setupRenderBufferStorage( renderbuffer, renderTarget, useMultisample ) {

_gl.bindRenderbuffer( _gl.RENDERBUFFER, renderbuffer );

Expand All @@ -1588,15 +1588,13 @@ function WebGLTextures( _gl, extensions, state, properties, capabilities, utils,
const glAttachmentType = renderTarget.stencilBuffer ? _gl.DEPTH_STENCIL_ATTACHMENT : _gl.DEPTH_ATTACHMENT;

// set up the attachment
const samples = getRenderTargetSamples( renderTarget );
const isUseMultisampledRTT = useMultisampledRTT( renderTarget );
if ( isUseMultisampledRTT ) {
if ( useMultisampledRTT( renderTarget ) ) {

multisampledRTTExt.renderbufferStorageMultisampleEXT( _gl.RENDERBUFFER, samples, glInternalFormat, renderTarget.width, renderTarget.height );
multisampledRTTExt.renderbufferStorageMultisampleEXT( _gl.RENDERBUFFER, getRenderTargetSamples( renderTarget ), glInternalFormat, renderTarget.width, renderTarget.height );

} else if ( isMultisample ) {
} else if ( useMultisample ) {

_gl.renderbufferStorageMultisample( _gl.RENDERBUFFER, samples, glInternalFormat, renderTarget.width, renderTarget.height );
_gl.renderbufferStorageMultisample( _gl.RENDERBUFFER, getRenderTargetSamples( renderTarget ), glInternalFormat, renderTarget.width, renderTarget.height );

} else {

Expand All @@ -1617,15 +1615,14 @@ function WebGLTextures( _gl, extensions, state, properties, capabilities, utils,
const glFormat = utils.convert( texture.format, texture.colorSpace );
const glType = utils.convert( texture.type );
const glInternalFormat = getInternalFormat( texture.internalFormat, glFormat, glType, texture.colorSpace );
const samples = getRenderTargetSamples( renderTarget );

if ( isMultisample && useMultisampledRTT( renderTarget ) === false ) {
if ( useMultisampledRTT( renderTarget ) ) {

_gl.renderbufferStorageMultisample( _gl.RENDERBUFFER, samples, glInternalFormat, renderTarget.width, renderTarget.height );
multisampledRTTExt.renderbufferStorageMultisampleEXT( _gl.RENDERBUFFER, getRenderTargetSamples( renderTarget ), glInternalFormat, renderTarget.width, renderTarget.height );

} else if ( useMultisampledRTT( renderTarget ) ) {
} else if ( useMultisample ) {

multisampledRTTExt.renderbufferStorageMultisampleEXT( _gl.RENDERBUFFER, samples, glInternalFormat, renderTarget.width, renderTarget.height );
_gl.renderbufferStorageMultisample( _gl.RENDERBUFFER, getRenderTargetSamples( renderTarget ), glInternalFormat, renderTarget.width, renderTarget.height );

} else {

Expand Down