Inform the user in case of parsing errors

Author: mpourmpoulis

CHANGELOG.md

@@ -8,6 +8,8 @@
 
 * in the tiebreak module function tiebreak_on_visual has been added, to enable more coherent tie-breaking
 
+* PopUpErrorAction has been added in order to inform the user in  cases where to cannot parse the source code.
+
 ### Fixed
 
 * fixed the empty brackets bug in the repair modulebugs with ":" addressed, needs more testing and a subsequent bug
@@ -52,6 +54,10 @@
 
 * additionally, even in case of ties when tie-breaking on the lowest common ancestor, the visual proximity is now taken into account!
 
+* in the partial module, the function partially_parse has been modified in order to accept one more optional Boolean parameter which when True causes the function to raise the initial syntax error it captured instead of returning None objects. By default the parameter is set to False.
+
+* In the same spirit, the query module has been modified and has a new attribute in order to store the above exception. The application module checks if this attribute HUD stored exception and displays an error through the PopUpErrorAction!
+
 ## [0.0.3] - 2019-11-18
 
 important patch

application/application.py

@@ -39,7 +39,15 @@ def respond_to_query(self,interface,query_description):
 
 		# get the corresponding query and execute it
 		s = get_query(query_description)(code,latest_build)
-		s(view_information,query_description,extra)
+		try:
+			s(view_information,query_description,extra)
+		except:
+			pass
+
+		# check if there are exceptions
+		if s.exceptions_raised:
+			interface.push_action(PopUpErrorAction(str(s.exceptions_raised)))
+		print(s.exceptions_raised)
 
 		# register build for later use
 		b = s.get_the_latest_build()

doc/SelectArgument.md

@@ -107,7 +107,10 @@ But why both "above" and "up"? The difference lies in that above only counts "in
 
 ![](./gif/arg5.gif)
 
-Please also pay attention to the fact that logical lines can extend over multiple "physical" lines. In such a case, as illustrated by the last example in the gif, physical lines still determine the line to which above/below refer  and result and  alternatives from that physical line will be prioritized, but alternatives will also be offered from  the whole logical line!  Other than that like case one.
+Though if we want to be more precise, we count lines that contain the beginning of function calls! this is important because logical lines can extend over multiple "physical" lines. The last example in the gif contains such an example, physical lines still determine the line to which above/below refer  and result and  alternatives from that physical line will be prioritized, but alternatives will also be offered from  the whole logical line! 
+
+
+
 
 ## Case three
 

interface/common/actions.py

@@ -1,3 +1,5 @@
+import html
+
 class InterfaceAction():
 	"""docstring for InterfaceAction"""
 	def __init__(self):
@@ -207,6 +209,20 @@ def execute(self,view,window,sublime,**kwargs):
 		window.run_command("hide_panel",{"panel":"console"}) 
 		window.run_command("show_panel",{"panel":"output.python_voice_coding_plugin_panel"})
 
+class PopUpErrorAction(InterfaceAction):
+	"""docstring for DisplayErrorAction"""
+	def __init__(self, text):
+		self.text = text
+	def execute(self,view, sublime,**kwargs):
+		final_text = "<p></p><h>Something is off!</h>" + "<p>" + html.escape(self.text) + "</p>"
+		print(" inside final text processing ",final_text)
+		def on_hide():
+			view.show_popup(final_text,max_width=1024, max_height=10000, flags= sublime.COOPERATE_WITH_AUTO_COMPLETE)
+		view.show_popup(final_text,max_width=1024, max_height=10000, 
+			flags= sublime.COOPERATE_WITH_AUTO_COMPLETE,on_hide = on_hide)
+		print(view.is_popup_visible())
+
+#  style=\"background-color:#000080\"
 
 
 

library/partial.py

@@ -30,17 +30,17 @@
 ################################################################################################
 ################################################################################################
 
-def partially_parse(code, m = None, atok = None):
+def partially_parse(code, m = None, atok = None,rethrow_exception = False):
 	m = m if m is not None else ModificationHandler(code)
 	#print(code)
 	timestamp = m.get_timestamp()
 	try:
 		root,atok = build_tree(code) 
 		r = RepairMissing(atok,m,timestamp)
 		return root,atok,m,r
-	except: 
+	except Exception as e_first: 
 		atok =  atok  if atok  else asttokens.ASTTokens(parse=False, source_text= code)
-		print(m)
+		# print(m)
 		m = filter_everything(atok,m, timestamp)
 		m.update()
 		#print("after filtering",m.history)
@@ -54,16 +54,16 @@ def partially_parse(code, m = None, atok = None):
 			return root,atok,m,r
 		except Exception as e:
 			print(" go to the field\n",m.current_code)
-			print(" error was\n",e)
+			print(" error was\n",str(e),"\n",e)
+			if rethrow_exception :
+				raise e_first
 			return None,None,None,None
 
 ###############################
 
 
 def line_partial(code,offset):	
-	print("inside bar shall align")
 	atok = asttokens.ASTTokens(parse=False, source_text=code)
-	print([x  for x in atok.tokens  if x.type== tokenize.NL])
 	origin = atok.get_token_from_offset(offset)
 	left, right = expand_to_line_or_statement(atok,origin)
 	print( left, right )

queries/abstract/query.py

@@ -5,7 +5,9 @@ class Query():
 	def __init__(self, code,latest_build = None):
 		self.code = code
 		self.general_build = latest_build
+		self.exceptions_raised = None
 		self.attempt_build()
+		
 
 
 	def __call__(self,view_information,query_description,extra = {}):
@@ -16,7 +18,10 @@ def get_the_latest_build(self):
 
 	def attempt_build(self):
 		if self.general_build is None:
-			self.general_build = partially_parse(self.code)
+			try:
+				self.general_build = partially_parse(self.code,rethrow_exception = True)
+			except Exception as e:
+				self.exceptions_raised = e
 
 	def _get_selection(self,view_information,extra = {}):
 		return extra["selection"] if "selection" in extra else view_information["selection"]

queries/big_roi.py

@@ -25,7 +25,7 @@ def preliminary(self,view_information,query_description, extra = {}):
 		selection = self._get_selection(view_information,extra)
 		build = self.general_build 
 		if not build  or not build[0] :
-			return None,None
+			return None,None,None,None
 		root,atok,m,r  = build 
 		selection = m.forward(selection)
 		origin = nearest_node_from_offset(root,atok, selection[0]) if selection[0]==selection[1] else node_from_range(root,atok, selection)