Skip to content

Commit 04d2fe9

Browse files
committed
Adding David's changes to paper
1 parent 34bcef8 commit 04d2fe9

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

docs/paper/paper.md

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,17 @@ bibliography: paper.bib
2424
# Summary
2525

2626
The fast Fourier transform (FFT) is an algorithm that efficiently
27-
computes the discrete Fourier transform. The FFT is an ubiquitous
27+
computes the discrete Fourier transform. The FFT is a ubiquitous
2828
algorithm utilized throughout science and engineering. Since the dawn
29-
of our digital society, the FFT permeated to the heart of everyday
30-
life applications involving audio, image, and video processing. The
29+
of our digital society, the FFT has permeated to the heart of everyday
30+
life applications involving audio, image, and video processing. The
31+
importance of the FFT extends beyond signal processing into scientific
32+
computing because it diagonalizes the Poisson operator, which is
33+
ubiquitous in descriptions of electromagnetism, gravitation,
34+
acoustic and elastic waves, potential flow in fluids, stress in
35+
solids, Hamiltonians of the Schroedinger’s equation for probability
36+
distribution of electrons in quantum mechanics, and diffusion of
37+
internal energy, chemical species, and momentum. The
3138
FFT has been named *the most important numerical algorithm of our
3239
time* by Prof Gilbert Strang [@strang94].
3340

@@ -38,7 +45,7 @@ multidimensional FFT is computed in sequence, over all axes, one axis
3845
at the time. In order to fit in the memory of multiple processors,
3946
multidimensional arrays have to be distributed along some, but not
4047
all, of its axes. Consequently, parallel FFTs are computed with
41-
successive sequential (serial) transforms over non-distributed axes,
48+
successive sequential (serial) transforms over undivided axes,
4249
combined with global array redistributions (using interprocess
4350
communication) that realign the arrays for further serial transforms.
4451

@@ -56,7 +63,7 @@ transforms.
5663

5764
``mpi4py-fft`` is highly configurable in how it distributes and
5865
redistributes arrays. Large arrays may be globally redistributed for
59-
alignement along any given axis, whenever needed by the user. This
66+
alignment along any given axis, whenever needed by the user. This
6067
flexibility has enabled the development of ``shenfun``
6168
[@mortensen_joss,@mortensen17], which is a Python framework for
6269
solving partial differential equations (PDEs) by the spectral Galerkin
@@ -85,7 +92,7 @@ useful.
8592
M Mortensen acknowledges support from the 4DSpace Strategic Research
8693
Initiative at the University of Oslo.
8794

88-
L Dalcin acknowledges support from the Extreme Computing Research
95+
L Dalcin and D Keyes acknowledge support from the Extreme Computing Research
8996
Center and the KAUST Supercomputing Laboratory at King Abdullah
9097
University of Science and Technology.
9198

mpi4py_fft/mpifft.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,9 @@ def local_shape(self, forward_output=False):
371371
"""
372372
import warnings
373373
warnings.warn("local_shape() is deprecated; use shape().", FutureWarning)
374-
return self.shape(forward_output)
374+
if forward_output is not True:
375+
return self.forward.input_pencil.subshape
376+
return self.backward.input_pencil.subshape
375377

376378
def global_shape(self, forward_output=False):
377379
"""Return global shape of associated tensors

0 commit comments

Comments
 (0)