Skip to content

Commit 35248b8

Browse files
committed
get rid of else condition in is_new_better
1 parent 0ebb56c commit 35248b8

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

treeherder/perf/stats.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ def interpret_cles_direction(cles, pvalue_threshold=PVALUE_THRESHOLD):
316316

317317

318318
def is_new_better(is_effect_meaningful, is_base_greater, is_significant, lower_is_better):
319+
is_new_better = None
320+
direction = "no change"
319321
# Possibility Base > than New with a small amount or more significance
320322
if is_base_greater and is_effect_meaningful and is_significant:
321323
if lower_is_better:
@@ -332,9 +334,6 @@ def is_new_better(is_effect_meaningful, is_base_greater, is_significant, lower_i
332334
else:
333335
is_new_better = True
334336
direction = "improvement"
335-
else:
336-
is_new_better = None
337-
direction = "no change"
338337
return direction, is_new_better
339338

340339

0 commit comments

Comments
 (0)