From 64bf0ccfff545449934843fb8f3a70822cb573d7 Mon Sep 17 00:00:00 2001 From: Ger Hobbelt Date: Tue, 18 Jun 2019 19:51:47 +0200 Subject: [PATCH] binary-search: + `===` precise numeric enum check for bias + typo fix in comment --- lib/binary-search.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/binary-search.js b/lib/binary-search.js index d6f898ea..bc29a44b 100644 --- a/lib/binary-search.js +++ b/lib/binary-search.js @@ -45,7 +45,7 @@ function recursiveSearch(aLow, aHigh, aNeedle, aHaystack, aCompare, aBias) { // The exact needle element was not found in this haystack. Determine if // we are in termination case (3) or (2) and return the appropriate thing. - if (aBias == exports.LEAST_UPPER_BOUND) { + if (aBias === exports.LEAST_UPPER_BOUND) { return aHigh < aHaystack.length ? aHigh : -1; } return mid; @@ -93,7 +93,7 @@ exports.search = function search(aNeedle, aHaystack, aCompare, aBias) { return -1; } - // We have found either the exact element, or the next-closest element than + // We have found either the exact element, or the next-closest element to // the one we are searching for. However, there may be more than one such // element. Make sure we always return the smallest of these. while (index - 1 >= 0) {