Skip to content

Change with type to overload #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change with type to overload #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source-map.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ export interface SourceMapConsumerConstructor {
* console.log(xSquared);
* ```
*/
with<T>(rawSourceMap: RawSourceMap, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: BasicSourceMapConsumer) => Promise<T> | T): Promise<T>;
with<T>(rawSourceMap: RawIndexMap, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: IndexedSourceMapConsumer) => Promise<T> | T): Promise<T>;
with<T>(rawSourceMap: RawSourceMap | RawIndexMap | string, sourceMapUrl: SourceMapUrl | null | undefined, callback: (consumer: BasicSourceMapConsumer | IndexedSourceMapConsumer) => Promise<T> | T): Promise<T>;
Comment on lines +239 to 241
Copy link
Contributor

@ochameau ochameau Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. I might see an improvement if you were removing the 3rd line 241.
So that we either type rawSourceMap as RawSourceMap or as RawIndex, but as-is the last line still allow mixed types.

}

Expand Down