refactor(db): Fixes #340 Remove column createdAt on recoveryCode table (#342), r=@vbudhram

Author: deeptibaghel

lib/db/mysql.js

@@ -1456,7 +1456,7 @@ module.exports = function (log, error) {
   }
 
   const DELETE_RECOVERY_CODES = 'CALL deleteRecoveryCodes_1(?)'
-  const INSERT_RECOVERY_CODE = 'CALL createRecoveryCode_2(?, ?, ?)'
+  const INSERT_RECOVERY_CODE = 'CALL createRecoveryCode_3(?, ?, ?)'
   MySql.prototype.replaceRecoveryCodes = function (uid, count) {
 
     // Because of the hashing requirements the process of replacing

lib/db/patch.js

@@ -4,4 +4,4 @@
 
 // The expected patch level of the database. Update if you add a new
 // patch in the ./schema/ directory.
-module.exports.level = 79
+module.exports.level = 80

lib/db/schema/patch-079-080.sql

@@ -0,0 +1,18 @@
+SET NAMES utf8mb4 COLLATE utf8mb4_bin;
+
+-- createdAt value is never returned to the user and not used internally
+
+ALTER TABLE recoveryCodes DROP COLUMN createdAt;
+
+CREATE PROCEDURE `createRecoveryCode_3` (
+  IN `uidArg` BINARY(16),
+  IN `codeHashArg` BINARY(32),
+  IN `saltArg` BINARY(32)
+)
+BEGIN
+
+  INSERT INTO recoveryCodes (uid, codeHash, salt) VALUES (uidArg, codeHashArg, saltArg);
+
+END;
+
+UPDATE dbMetadata SET value = '80' WHERE name = 'schema-patch-level';

lib/db/schema/patch-080-079.sql

@@ -0,0 +1,6 @@
+-- SET NAMES utf8mb4 COLLATE utf8mb4_bin;
+
+-- DROP PROCEDURE `createRecoveryCode_3`;
+-- ALTER TABLE  recoveryCodes ADD createdAt BIGINT UNSIGNED NOT NULL;
+
+-- UPDATE dbMetadata SET value = '79' WHERE name = 'schema-patch-level';