Commit 33c26aa
authored
Implement all commands of Ctap2 (#154)
* WIP: Add part MakeCredentials
* Add test for (and do some fixes) for MakeCredential CTAP1 mapping
* Adjust tests with RelyingParty and name-field
* Fix serialization of MakeCredentialOptions (individually serialize members)
* Temporarily parse credential_public_key just as a byte-vector, until COSE-crate is added and able to actually parse it
* Add Option Unparsed to AttestationStatement, to currently skip parsing it (which would need a DER-parser)
* Add commands GetAssertion and GetAssertionNext. Still missing tests.
* WIP: Add clientpin command with all the crypto functionality commented out
* Remove duplicate Pin-definition
* MakeCredentials and GetAssertion now do not store Pin but PinAuth, which has to be calculated before hand
* MakeCredentials: Remove pointless alias for HIDError
* GetInfo: Fix wrong parsing of response. Forgot to strip away the status-byte
* Make naming of CommandError variants consistent and remove redundant 'Parsing'-variant
* Replace custom error with invalid_length (even though the usage is a bit weird)
* Use From<CommandError>-trait of HIDError to avoid verbose map_err-calls, by using the shorter .into()
Co-authored-by: Martin Sirringhaus <>1 parent 3377167 commit 33c26aa
File tree
16 files changed
+3880
-20
lines changed- src
- ctap2
- commands
- transport
16 files changed
+3880
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
51 | 52 | | |
52 | | - | |
| 53 | + | |
53 | 54 | | |
54 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | | - | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| 64 | + | |
0 commit comments