MOBILE-4575 user: Sort user initials depending on translation

Author: crazyserver

scripts/langindex.json

@@ -2670,6 +2670,7 @@
   "core.user.emailagain": "moodle",
   "core.user.errorloaduser": "local_moodlemobileapp",
   "core.user.firstname": "moodle",
+  "core.user.fullnamedisplay": "moodle",
   "core.user.idnumber": "moodle",
   "core.user.institution": "moodle",
   "core.user.interests": "moodle",

src/core/features/user/lang.json

@@ -18,6 +18,7 @@
     "emailagain": "Email (again)",
     "errorloaduser": "Error loading user.",
     "firstname": "First name",
+    "fullnamedisplay": "{{$a.firstname}} {{$a.lastname}}",
     "idnumber": "ID number",
     "institution": "Institution",
     "interests": "Interests",

src/core/features/user/services/user-helper.ts

@@ -108,27 +108,35 @@ export class CoreUserHelperProvider {
      * @returns User initials.
      */
     async getUserInitialsFromParts(parts: CoreUserNameParts): Promise<string> {
+        const nameFields = ['firstname', 'lastname'];
+        const dummyUser = {
+            firstname: 'firstname',
+            lastname: 'lastname',
+        };
+        const nameFormat = Translate.instant('core.user.fullnamedisplay', { $a:dummyUser });
+        const availableFieldsSorted = nameFields
+            .filter((field) => nameFormat.indexOf(field) >= 0)
+            .sort((a, b) => nameFormat.indexOf(a) - nameFormat.indexOf(b));
+
         if (!parts.firstname && !parts.lastname) {
-            if (!parts.fullname && parts.userId) {
+            if (parts.userId) {
                 const user = await CoreUser.getProfile(parts.userId, undefined, true);
-                parts.fullname = user.fullname || '';
-            }
-
-            if (parts.fullname) {
+                parts.firstname = user.firstname || '';
+                parts.lastname = user.lastname || '';
+            } else if (parts.fullname) {
+                // It's a complete workaround.
                 const split = parts.fullname.split(' ');
-
                 parts.firstname = split[0];
                 if (split.length > 1) {
                     parts.lastname = split[split.length - 1];
                 }
             }
         }
 
-        if (!parts.firstname && !parts.lastname) {
-            return 'UNK';
-        }
+        const initials = availableFieldsSorted.reduce((initials, fieldName) =>
+            initials + (parts[fieldName]?.charAt(0) ?? ''), '');
 
-        return (parts.firstname?.charAt(0) || '') + (parts.lastname?.charAt(0) || '');
+        return initials || 'UNK';
     }
 
     /**

src/core/features/user/tests/user-helper.test.ts

@@ -12,9 +12,17 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import { mockSingleton, mockTranslate } from '@/testing/utils';
 import { CoreUserHelper } from '../services/user-helper';
+import { CoreUser } from '../services/user';
 
 describe('getUserInitialsFromParts', () => {
+  beforeEach(() => {
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.firstname}} {{$a.lastname}}',
+    });
+  });
+
   it('should return initials based on firstname and lastname', async () => {
     const parts = {
       firstname: 'John',
@@ -23,13 +31,53 @@ describe('getUserInitialsFromParts', () => {
       userId: 123,
     };
 
-    const result = await CoreUserHelper.getUserInitialsFromParts(parts);
+    let result = await CoreUserHelper.getUserInitialsFromParts(parts);
 
     expect(result).toEqual('JD');
+
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.lastname}} {{$a.firstname}}',
+    });
+
+    result = await CoreUserHelper.getUserInitialsFromParts(parts);
+
+    expect(result).toEqual('DJ');
+
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.lastname}}',
+    });
+
+    result = await CoreUserHelper.getUserInitialsFromParts(parts);
+
+    expect(result).toEqual('D');
+
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.firstname}}',
+    });
+
+    result = await CoreUserHelper.getUserInitialsFromParts(parts);
+
+    expect(result).toEqual('J');
+
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.noname}}',
+    });
+
+    result = await CoreUserHelper.getUserInitialsFromParts(parts);
+
+    expect(result).toEqual('UNK');
   });
 
   it('should return initials based on fullname if firstname and lastname are missing', async () => {
-    let parts = {
+    mockSingleton(CoreUser, {
+        getProfile: () => Promise.resolve({
+          firstname: 'John',
+          lastname: 'Doe',
+          fullname: 'John Doe',
+          id: 123,
+    }) });
+
+    let parts: { firstname?: string; lastname?: string; fullname?: string; userId?: number } = {
       firstname: '',
       lastname: '',
       fullname: 'John Doe',
@@ -44,12 +92,19 @@ describe('getUserInitialsFromParts', () => {
         firstname: '',
         lastname: '',
         fullname: 'John Fitzgerald Doe',
-        userId: 123,
     };
 
     result = await CoreUserHelper.getUserInitialsFromParts(parts);
 
     expect(result).toEqual('JD');
+
+    mockTranslate({
+      'core.user.fullnamedisplay': '{{$a.lastname}} {{$a.firstname}}',
+    });
+
+    result = await CoreUserHelper.getUserInitialsFromParts(parts);
+
+    expect(result).toEqual('DJ');
   });
 
   it('should return UNK string if empty parts', async () => {