Add option --scss-deprecations for behat

Author: marinaglancy

.github/workflows/test.yml

@@ -152,7 +152,7 @@ jobs:
         moodle-plugin-ci phpdoc
         moodle-plugin-ci phpunit --verbose --coverage-text --fail-on-warning
         moodle-plugin-ci behat --profile default
-        moodle-plugin-ci behat --profile chrome
+        moodle-plugin-ci behat --profile chrome --scss-deprecations
         moodle-plugin-ci behat --profile firefox --tags="@local_ci&&~@app"
 
   buildphar:
@@ -279,7 +279,7 @@ jobs:
         php build/moodle-plugin-ci.phar phpdoc
         php build/moodle-plugin-ci.phar phpunit --verbose --coverage-text --fail-on-warning
         php build/moodle-plugin-ci.phar behat --profile default
-        php build/moodle-plugin-ci.phar behat --profile chrome
+        php build/moodle-plugin-ci.phar behat --profile chrome --scss-deprecations
         php build/moodle-plugin-ci.phar behat --profile firefox --tags="@local_ci&&~@app"
 
   selfupdatetest:

docs/CHANGELOG.md

@@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com).
 
+## [Unreleased]
+### Added
+- Allow to run with PHP 8.4 (supported in Moodle 5.0)
+- New `--scss-deprecations` option added to the `behat` command
+
 ## [4.5.6] - 2025-01-31
 ### Fixed
 - Removed the PHPUnit --verbose option to comply with Moodle 5.0

docs/CLI.md

@@ -347,6 +347,16 @@ Print contents of Behat failure HTML files
 * Is negatable: no
 * Default: `false`
 
+#### `--scss-deprecations`
+
+Enable SCSS deprecation checks
+
+* Accept value: no
+* Is value required: no
+* Is multiple: no
+* Is negatable: no
+* Default: `false`
+
 #### `--help|-h`
 
 Display help for the given command. When no command is given display help for the list command

gha.dist.yml

@@ -106,7 +106,7 @@ jobs:
       - name: Behat features
         id: behat
         if: ${{ !cancelled() }}
-        run: moodle-plugin-ci behat --profile chrome
+        run: moodle-plugin-ci behat --profile chrome --scss-deprecations
 
       - name: Upload Behat Faildump
         if: ${{ failure() && steps.behat.outcome == 'failure' }}

src/Command/BehatCommand.php

@@ -48,6 +48,7 @@ protected function configure(): void
             ->addOption('auto-rerun', null, InputOption::VALUE_REQUIRED, 'Number of times to rerun failures', 2)
             ->addOption('selenium', null, InputOption::VALUE_REQUIRED, 'Selenium Docker image')
             ->addOption('dump', null, InputOption::VALUE_NONE, 'Print contents of Behat failure HTML files')
+            ->addOption('scss-deprecations', null, InputOption::VALUE_NONE, 'Enable SCSS deprecation checks')
             ->setDescription('Run Behat on a plugin');
     }
 
@@ -72,6 +73,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $servers && $this->startServerProcesses($input);
 
+        if ($input->getOption('scss-deprecations')) {
+            $enableprocess = new Process([
+                'php', 'admin/tool/behat/cli/util_single_run.php',
+                '--enable',
+                '--add-core-features-to-theme',
+                '--scss-deprecations',
+            ], $this->moodle->directory, null, null, null);
+            $this->execute->passThroughProcess($enableprocess);
+        }
+
         $cmd = [
             'php', 'admin/tool/behat/cli/run.php',
             '--profile=' . $input->getOption('profile'),

tests/Command/BehatCommandTest.php

@@ -127,6 +127,13 @@ public function testExecuteWithName()
         $this->assertMatchesRegularExpression("/{$expectedName}/", $this->lastCmd);
     }
 
+    public function testExecuteWithScssDeprecations()
+    {
+        $commandTester = $this->executeCommand(null, null, ['--scss-deprecations' => true]);
+        $this->assertSame(0, $commandTester->getStatusCode());
+        $this->assertMatchesRegularExpression('/--scss-deprecations/', $this->allCmds[0]);
+    }
+
     public function testExecuteNoFeatures()
     {
         $this->fs->remove($this->pluginDir . '/tests/behat');