Fix MONGOID-5366 #upsert misuses #update_one

 (#5294)

* Fix MONGOID-5366 #upsert misuses #update_one

* add release notes documentation

Co-authored-by: Oleg Pudeyev <code@olegp.name>

Author: p-mongo

docs/release-notes/mongoid-7.4.txt

@@ -572,3 +572,11 @@ inside a hash. For example:
 
   In Mongoid 8.0, the default value of the ``Mongoid.legacy_pluck_distinct`` option will
   change to ``false``.
+
+
+``update_one`` Warnings in ``upsert``
+-------------------------------------
+
+Mongoid 7.4.1 fixes incorrect usage of the driver's ``update_one`` method from
+Mongoid's ``upsert`` method. Mongoid's ``upsert`` actually performs a
+replacing upsert, and Mongoid 7.4.1 and later correctly call ``replace_one``.

docs/release-notes/mongoid-7.5.txt

@@ -80,3 +80,10 @@ The following functions are affected by this change:
    the selector can be strings or symbols, depending on what was passed to the
    operator.
 
+
+``update_one`` Warnings in ``upsert``
+-------------------------------------
+
+Mongoid 7.5 fixes incorrect usage of the driver's ``update_one`` method from
+Mongoid's ``upsert`` method. Mongoid's ``upsert`` actually performs a
+replacing upsert, and Mongoid 7.5 correctly calls ``replace_one``.

lib/mongoid/persistable/upsertable.rb

@@ -18,7 +18,7 @@ module Upsertable
       # @return [ true ] True.
       def upsert(options = {})
         prepare_upsert(options) do
-          collection.find(atomic_selector).update_one(
+          collection.find(atomic_selector).replace_one(
               as_attributes, upsert: true, session: _session)
         end
       end