address pr comments

Author: anandsyncs

docs/search/01-search-community-deploy/code_snippets/01_0040_validate_env.sh

@@ -0,0 +1,36 @@
+required=(
+  K8S_CTX
+  MDB_NS
+  MDB_RESOURCE_NAME
+  MDB_VERSION
+  MDB_MEMBERS
+  CERT_MANAGER_NAMESPACE
+  MDB_TLS_CA_SECRET_NAME
+  MDB_TLS_SERVER_CERT_SECRET_NAME
+  MDB_SEARCH_TLS_SECRET_NAME
+  MDB_ADMIN_USER_PASSWORD
+  MDB_SEARCH_SYNC_USER_PASSWORD
+  MDB_USER_PASSWORD
+  OPERATOR_HELM_CHART
+)
+
+optional=(
+  OPERATOR_ADDITIONAL_HELM_VALUES
+  PRERELEASE_IMAGE_PULLSECRET
+)
+
+missing_req=()
+for v in "${required[@]}"; do [[ -n "${!v:-}" ]] || missing_req+=("$v"); done
+if (( ${#missing_req[@]} )); then
+  echo "ERROR: Missing required environment variables:" >&2
+  for m in "${missing_req[@]}"; do echo "  - $m" >&2; done
+  exit 1
+fi
+
+missing_opt=()
+for v in "${optional[@]}"; do [[ -n "${!v:-}" ]] || missing_opt+=("$v"); done
+
+echo "All required environment variables present."
+if (( ${#missing_opt[@]} )); then
+  echo "Optional variables missing (will continue): ${missing_opt[*]}"
+fi

docs/search/01-search-community-deploy/code_snippets/01_0305_create_mongodb_community_user_secrets.sh

@@ -1,13 +1,16 @@
-create_secret() {
-    local secret_name="$1"
-    local password_var="$2"
+# Create admin user secret
+kubectl create secret generic mdb-admin-user-password \
+  --from-literal=password="${MDB_ADMIN_USER_PASSWORD}" \
+  --dry-run=client -o yaml | kubectl apply --context "${K8S_CTX}" --namespace "${MDB_NS}" -f -
 
-    kubectl create secret generic "${secret_name}" \
-        --from-literal=password="${password_var}" \
-        --dry-run=client -o yaml \
-        | kubectl apply --context "${K8S_CTX}" --namespace "${MDB_NS}" -f -
-}
+# Create search sync source user secret
+kubectl create secret generic "${MDB_RESOURCE_NAME}-search-sync-source-password" \
+  --from-literal=password="${MDB_SEARCH_SYNC_USER_PASSWORD}" \
+  --dry-run=client -o yaml | kubectl apply --context "${K8S_CTX}" --namespace "${MDB_NS}" -f -
 
-create_secret "mdb-admin-user-password" "${MDB_ADMIN_USER_PASSWORD}"
-create_secret "${MDB_RESOURCE_NAME}-search-sync-source-password" "${MDB_SEARCH_SYNC_USER_PASSWORD}"
-create_secret "mdb-user-password" "${MDB_USER_PASSWORD}"
+# Create regular user secret
+kubectl create secret generic mdb-user-password \
+  --from-literal=password="${MDB_USER_PASSWORD}" \
+  --dry-run=client -o yaml | kubectl apply --context "${K8S_CTX}" --namespace "${MDB_NS}" -f -
+
+echo "User secrets created."

docs/search/01-search-community-deploy/code_snippets/01_0306_configure_cert_manager_tls.sh

@@ -1,16 +1,3 @@
-required=(
-  K8S_CTX
-  CERT_MANAGER_NAMESPACE
-)
-missing=()
-for var in "${required[@]}"; do
-  [[ -n "${!var:-}" ]] || missing+=("${var}")
-done
-if (( ${#missing[@]} )); then
-  echo "Missing required environment variables: ${missing[*]}" >&2
-  exit 1
-fi
-
 helm repo add jetstack https://charts.jetstack.io --force-update >/dev/null 2>&1 || true
 helm upgrade --install \
   cert-manager jetstack/cert-manager \

docs/search/01-search-community-deploy/code_snippets/01_0306_install_cert_manager.sh

@@ -1,18 +1,3 @@
-required=(
-  K8S_CTX
-  MDB_NS
-  MDB_RESOURCE_NAME
-  MDB_TLS_CA_SECRET_NAME
-)
-missing=()
-for var in "${required[@]}"; do
-  [[ -n "${!var:-}" ]] || missing+=("${var}")
-done
-if (( ${#missing[@]} )); then
-  echo "Missing required environment variables: ${missing[*]}" >&2
-  exit 1
-fi
-
 self_signed_issuer="${MDB_RESOURCE_NAME}-selfsigned-issuer"
 ca_cert_name="${MDB_RESOURCE_NAME}-ca"
 ca_issuer="${MDB_RESOURCE_NAME}-ca-issuer"

docs/search/01-search-community-deploy/code_snippets/01_0307_prepare_cert_manager_issuer.sh

@@ -1,21 +1,3 @@
-required=(
-  K8S_CTX
-  MDB_NS
-  MDB_RESOURCE_NAME
-  MDB_MEMBERS
-  MDB_TLS_CA_SECRET_NAME
-  MDB_TLS_SERVER_CERT_SECRET_NAME
-  MDB_SEARCH_TLS_SECRET_NAME
-)
-missing=()
-for var in "${required[@]}"; do
-  [[ -n "${!var:-}" ]] || missing+=("${var}")
-done
-if (( ${#missing[@]} )); then
-  echo "Missing required environment variables: ${missing[*]}" >&2
-  exit 1
-fi
-
 ca_issuer="${MDB_RESOURCE_NAME}-ca-issuer"
 server_certificate="${MDB_RESOURCE_NAME}-server-tls"
 search_certificate="${MDB_RESOURCE_NAME}-search-tls"
@@ -31,8 +13,6 @@ mongo_dns_names+=(
 )
 
 search_dns_names=(
-  "${MDB_RESOURCE_NAME}-search-0"
-  "${MDB_RESOURCE_NAME}-search-0.${MDB_RESOURCE_NAME}-search-svc.${MDB_NS}.svc.cluster.local"
   "${MDB_RESOURCE_NAME}-search-svc.${MDB_NS}.svc.cluster.local"
 )
 

docs/search/01-search-community-deploy/code_snippets/01_0308_issue_tls_certificates.sh

@@ -11,6 +11,7 @@ cd "${script_dir}"
 
 prepare_snippets
 
+run 01_0040_validate_env.sh
 run 01_0045_create_namespaces.sh
 run 01_0046_create_image_pull_secrets.sh
 run 01_0048_configure_prerelease_image_pullsecret.sh

docs/search/01-search-community-deploy/test.sh

@@ -40,8 +40,6 @@ spec:
   - server auth
   - client auth
   dnsNames:
-  - "${MDB_RESOURCE_NAME}-search-0"
-  - "${MDB_RESOURCE_NAME}-search-0.${MDB_RESOURCE_NAME}-search-svc.${MDB_NS}.svc.cluster.local"
   - "${MDB_RESOURCE_NAME}-search-svc.${MDB_NS}.svc.cluster.local"
 EOF_MANIFEST