Skip to content

Commit 632e21a

Browse files
authored
Fix master builds - it was using BuildScenario.DEVELOPMENT for master merges by mistake (#404)
# Summary Master merges CI builds are failing. This is because we wrongly interpret them as `BuildScenario.DEVELOPMENT` instead if `BuildScenario.PATCH`. For example [this](https://parsley.mongodb.com/evergreen/mongodb_kubernetes_init_test_run_build_test_image_38b6aa8dae4129bcd35299d679580179481a6980_25_09_04_05_33_35/0/all?bookmarks=0,3863) meko-test build on master pushed image using only latest tag, that is used for `BuildScenario.DEVELOPMENT`. To fix this (before we activate staging builds) we need to return `BuildScenario.PATCH` if `is_patch` is true or `is_evg` true. ## Proof of Work Passing CI for PR is enough. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
1 parent 38b6aa8 commit 632e21a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/release/build/build_scenario.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def infer_scenario_from_environment(cls) -> "BuildScenario":
3030
# Release scenario and the git tag will be used for promotion process only
3131
scenario = BuildScenario.RELEASE
3232
logger.info(f"Build scenario: {scenario} (git_tag: {git_tag})")
33-
elif is_patch and is_evg:
33+
elif is_patch or is_evg:
3434
scenario = BuildScenario.PATCH
3535
logger.info(f"Build scenario: {scenario} (patch_id: {patch_id})")
3636
# TODO: Uncomment the following lines when starting to work on staging builds

0 commit comments

Comments
 (0)