Normalize GKE identifiers in snippets (#458)

# Summary

When executed from a tag build, the version_id is long and contains dots
which are unacceptable by GKE.

Additionally it reduces verbose output when installing gcloud.

## Proof of Work

EVG run with --param
override_version_id=mongodb_kubernetes_1.4.0_68c913f767d52d00076a2698

## Checklist

- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [ ] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you added changelog file?
    - use `skip-changelog` label if not needed
- refer to [Changelog files and Release
Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes)
section in CONTRIBUTING.md for more details

Author: lsierant

public/architectures/setup-multi-cluster/ra-09-setup-externaldns/env_variables.sh

@@ -12,9 +12,8 @@
 #  ${K8S_CLUSTER_2_CONTEXT_NAME}
 #  ${MDB_GKE_PROJECT}
 
-# Example K8S_CLUSTER_SUFFIX when running in evg: "-68c1dc3ffdfb5800075ecee0-26080"
 suffix_short="${K8S_CLUSTER_SUFFIX}"
-# Ensure suffix_short is no longer than 19 characters to make DNS_SA_NAME fit max 30 characters
+# Ensure suffix_short is no longer than 19 characters to make GKE identifiers fit under 30 characters
 if [[ -n "${suffix_short}" && ${#suffix_short} -gt 19 ]]; then
     # Calculate positions for cutting from the middle
     prefix_len=$(((19 - 1) / 2))  # -1 for the 'x' replacement
@@ -27,4 +26,4 @@ export DNS_SA_NAME="ext-dns-sa${suffix_short}"
 export DNS_SA_EMAIL="${DNS_SA_NAME}@${MDB_GKE_PROJECT}.iam.gserviceaccount.com"
 
 export CUSTOM_DOMAIN="mongodb.custom"
-export DNS_ZONE="mongodb"
+export DNS_ZONE="mongodb${suffix_short}"

scripts/dev/contexts/funcs/gke

@@ -0,0 +1,33 @@
+# Function to normalize identifier to contain only alphanumeric characters.
+# It's also cutting the string in the middle if exceeds max_len.
+# Example:
+#   normalize_identifier "mongodb_kubernetes_1.4.0_68c913f767d52d00076a2698" 25 -> mongodb-kubex2d00076a2698
+normalize_identifier() {
+    local str=$1
+    local max_len=$(($2 - 1))
+
+    # Convert to lowercase and replace invalid characters with hyphens
+    str=$(echo -n "${str}" | tr '[:upper:]_' '[:lower:]-' | sed 's/[^a-z0-9-]/-/g')
+    # Ensure it ends with alphanumeric
+
+    # Truncate to ${max_len} chars by cutting from middle
+    if [[ ${#str} -gt ${max_len} ]]; then
+        half_idx=$((max_len / 2))
+        local start_part="${str:0:${half_idx}}"
+        local end_part="${str: -${half_idx}}"
+        str="${start_part}x${end_part}"
+    fi
+
+    [[ ${str} =~ -$ ]] && str="${str}0"
+    echo -n "${str}"
+}
+
+# for prerelease tag builds we have:
+# version_id=mongodb_kubernetes_1.4.0_68c913f767d52d00076a2698-9041 (len=54)
+# k8s cluster name prefix: k8s-mdb-0- (len=10)
+# random suffix: -1234 (len=5)
+# K8S_CLUSTER_PREFIX must be shorter than 25 to make the final
+# gke identifier shorter than 40 characters.
+create_k8s_cluster_suffix() {
+  echo -n "$(normalize_identifier "${K8S_CLUSTER_SUFFIX:-"-${version_id}-${RANDOM}"}" 25)"
+}

scripts/dev/contexts/prerelease_gke_code_snippets

@@ -8,9 +8,12 @@ script_name=$(readlink -f "${BASH_SOURCE[0]}")
 script_dir=$(dirname "${script_name}")
 
 source "${script_dir}/root-context"
+source "${script_dir}/funcs/gke"
+K8S_CLUSTER_SUFFIX="$(create_k8s_cluster_suffix)"
+export K8S_CLUSTER_SUFFIX
 
 export MDB_GKE_PROJECT="scratch-kubernetes-team"
-export K8S_CLUSTER_SUFFIX="${K8S_CLUSTER_SUFFIX:-"-${version_id}-${RANDOM}"}"
+
 export CODE_SNIPPETS_COMMIT_OUTPUT=true
 
 # we reset evg host to use a default ~/.kube/config for GKE instead of the one from evg host

scripts/dev/contexts/private_gke_code_snippets

@@ -10,10 +10,13 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om80"
 
+source "${script_dir}/funcs/gke"
+K8S_CLUSTER_SUFFIX="$(create_k8s_cluster_suffix)"
+export K8S_CLUSTER_SUFFIX
+
 export KUBE_ENVIRONMENT_NAME=multi
 
 export MDB_GKE_PROJECT="scratch-kubernetes-team"
-export K8S_CLUSTER_SUFFIX="${K8S_CLUSTER_SUFFIX:-"-${version_id}-${RANDOM}"}"
 
 # we reset evg host to use a default ~/.kube/config for GKE instead of the one from evg host
 export EVG_HOST_NAME=""

scripts/dev/contexts/public_gke_code_snippets

@@ -9,11 +9,13 @@ script_dir=$(dirname "${script_name}")
 
 source "${script_dir}/root-context"
 
+source "${script_dir}/funcs/gke"
+K8S_CLUSTER_SUFFIX="$(create_k8s_cluster_suffix)"
+export K8S_CLUSTER_SUFFIX
+
 export KUBE_ENVIRONMENT_NAME=multi
 
 export MDB_GKE_PROJECT="scratch-kubernetes-team"
-# shellcheck disable=SC2154
-export K8S_CLUSTER_SUFFIX="${K8S_CLUSTER_SUFFIX:-"-${version_id}-${RANDOM}"}"
 
 # we reset evg host to use a default ~/.kube/config for GKE instead of the one from evg host
 export EVG_HOST_NAME=""

scripts/evergreen/setup_gcloud_cli.sh

@@ -4,7 +4,7 @@ set -Eeou pipefail
 source scripts/dev/set_env_context.sh
 
 curl -s --retry 3 -LO "https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-cli-linux-x86_64.tar.gz"
-tar xvf google-cloud-cli-linux-x86_64.tar.gz -C "${workdir}"
+tar xf google-cloud-cli-linux-x86_64.tar.gz -C "${workdir}"
 "${workdir}"/google-cloud-sdk/install.sh --quiet
 source "${workdir}/google-cloud-sdk/path.bash.inc"