Skip to content

Commit 302dca2

Browse files
Fix python unit tests
1 parent 15b9277 commit 302dca2

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

scripts/release/release_info.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ def convert_to_release_info_json(build_info: BuildInfo) -> dict:
6666

6767
for name, chart in build_info.helm_charts.items():
6868
output["helm-charts"][name] = {
69-
"repositories": chart.repositories,
69+
"registry": chart.registry,
70+
"repository": chart.repository,
7071
"version": DUMMY_VERSION,
7172
}
7273

scripts/release/tests/build_info_test.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ def test_load_build_info_development():
8383
},
8484
helm_charts={
8585
"mongodb-kubernetes": HelmChartInfo(
86-
repositories=["268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/helm-charts"],
86+
registry="268558157000.dkr.ecr.us-east-1.amazonaws.com",
87+
repository="dev/mongodb/helm-charts",
88+
region="us-east-1"
8789
)
8890
},
8991
)
@@ -167,7 +169,9 @@ def test_load_build_info_patch():
167169
},
168170
helm_charts={
169171
"mongodb-kubernetes": HelmChartInfo(
170-
repositories=["268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/helm-charts"],
172+
region="us-east-1",
173+
repository="dev/mongodb/helm-charts",
174+
registry="268558157000.dkr.ecr.us-east-1.amazonaws.com"
171175
)
172176
},
173177
)
@@ -272,7 +276,9 @@ def test_load_build_info_staging():
272276
},
273277
helm_charts={
274278
"mongodb-kubernetes": HelmChartInfo(
275-
repositories=["268558157000.dkr.ecr.us-east-1.amazonaws.com/staging/helm-charts"],
279+
registry="268558157000.dkr.ecr.us-east-1.amazonaws.com",
280+
repository="staging/mongodb/helm-charts",
281+
region="us-east-1",
276282
sign=True,
277283
)
278284
},
@@ -352,7 +358,9 @@ def test_load_build_info_release():
352358
},
353359
helm_charts={
354360
"mongodb-kubernetes": HelmChartInfo(
355-
repositories=["quay.io/mongodb/helm-charts"],
361+
registry="quay.io",
362+
repository="mongodb/helm-charts",
363+
region=None,
356364
sign=True,
357365
)
358366
},

scripts/release/tests/release_info_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,10 @@ def test_create_release_info_json():
4949
}
5050
},
5151
"helm-charts": {
52-
"mongodb-kubernetes": {"repositories": ["quay.io/mongodb/helm-charts"], "version": DUMMY_VERSION}
52+
"mongodb-kubernetes": {
53+
"registry": "quay.io",
54+
"repository": "mongodb/helm-charts",
55+
"version": DUMMY_VERSION}
5356
},
5457
}
5558
expected_release_info_json = json.dumps(expected_json, indent=2)

0 commit comments

Comments
 (0)