Commit 13d8bc6
authored
remove trailing commas and set consistent yaml width (#210)
# Summary
This pull request includes updates to improve YAML file handling and
fixes a minor issue in the `update_standalone` function. The most
important changes are grouped below:
### YAML Handling Improvements:
*
[`scripts/evergreen/release/helm_files_handler.py`](diffhunk://#diff-3e4bf7eb043336f19b2029c2f2b0c2d3497902c0b116255fc99fe6467ae1e453R81):
Added a new configuration to set the YAML line width to 4096 in the
`update_standalone_installer` function to prevent inconsistent line
wrapping in the CI and locally
### Bug Fix in Function Logic:
*
[`scripts/evergreen/release/update_helm_values_files.py`](diffhunk://#diff-362db66ba4c033cb3e6d12456bb89ac5782882ffc6f393e8f7d8d36b69aee0ffL60-R62):
Fixed the `update_standalone` function by removing trailing commas,
which were causing unintended behavior when calling the
`update_standalone_installer` function multiple times.
## Proof of Work
- consistent yaml formatting for linter (passing unit test variant)
## Checklist
- [x] Have you linked a jira ticket and/or is the ticket in the title?
- [x] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you checked for release_note changes?
## Reminder (Please remove this when merging)
- Please try to Approve or Reject Changes the PR, keep PRs in review as
short as possible
- Our Short Guide for PRs:
[Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0)
- Remember the following Communication Standards - use comment prefixes
for clarity:
* **blocking**: Must be addressed before approval.
* **follow-up**: Can be addressed in a later PR or ticket.
* **q**: Clarifying question.
* **nit**: Non-blocking suggestions.
* **note**: Side-note, non-actionable. Example: Praise
* --> no prefix is considered a question1 parent a9fce45 commit 13d8bc6
File tree
2 files changed
+8
-3
lines changed- scripts/evergreen/release
2 files changed
+8
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
63 | 67 | | |
64 | 68 | | |
65 | 69 | | |
| |||
0 commit comments