CLOUDP-316083: Release Integrations independent CRD & controller (#2399)

* CLOUDP-316083: Release Integrations

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* fixup samples config

* increase api tests

* Fixup helm tests

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

---------

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

Author: josvazg

PROJECT

@@ -151,4 +151,12 @@ resources:
   kind: AtlasBackupCompliancePolicy
   path: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1
   version: v1
+- api:
+    crdVersion: v1
+    namespaced: true
+  domain: mongodb.com
+  group: atlas
+  kind: AtlasThirdPartyIntegration
+  path: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1
+  version: v1
 version: "3"

internal/nextapi/v1/atlasthirdpartyintegration_types.go renamed to api/v1/atlasthirdpartyintegration_types.go

@@ -18,8 +18,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	"github.com/mongodb/mongodb-atlas-kubernetes/v2/api"
-	akov2 "github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1"
-	"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/nextapi/v1/status"
+	"github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/status"
 )
 
 func init() {
@@ -31,7 +30,7 @@ func init() {
 // +kubebuilder:object:root=true
 // +kubebuilder:printcolumn:name="Ready",type=string,JSONPath=`.status.conditions[?(@.type=="Ready")].status`
 // +kubebuilder:subresource:status
-// +groupName:=atlas.nextapi.mongodb.com
+// +groupName:=atlas.mongodb.com
 // +kubebuilder:resource:categories=atlas,shortName=atpi
 type AtlasThirdPartyIntegration struct {
 	metav1.TypeMeta   `json:",inline"`
@@ -65,7 +64,7 @@ func (atpi *AtlasThirdPartyIntegration) GetConditions() []metav1.Condition {
 // +kubebuilder:validation:XValidation:rule="!has(self.victorOps) || (self.type == 'VICTOR_OPS' && has(self.victorOps))",message="only VICTOR_OPS type may set victorOps fields"
 // +kubebuilder:validation:XValidation:rule="!has(self.webhook) || (self.type == 'WEBHOOK' && has(self.webhook))",message="only WEBHOOK type may set webhook fields"
 type AtlasThirdPartyIntegrationSpec struct {
-	akov2.ProjectDualReference `json:",inline"`
+	ProjectDualReference `json:",inline"`
 
 	// Type of the integration
 	// +kubebuilder:validation:Enum:=DATADOG;MICROSOFT_TEAMS;NEW_RELIC;OPS_GENIE;PAGER_DUTY;PROMETHEUS;SLACK;VICTOR_OPS;WEBHOOK
@@ -219,6 +218,6 @@ type AtlasThirdPartyIntegrationList struct {
 	Items           []AtlasThirdPartyIntegration `json:"items"`
 }
 
-func (i *AtlasThirdPartyIntegration) ProjectDualRef() *akov2.ProjectDualReference {
+func (i *AtlasThirdPartyIntegration) ProjectDualRef() *ProjectDualReference {
 	return &i.Spec.ProjectDualReference
 }

internal/nextapi/v1/atlasthirdpartyintegration_types_test.go renamed to api/v1/atlasthirdpartyintegration_types_test.go

@@ -15,8 +15,10 @@
 package v1
 
 import (
+	"fmt"
 	"testing"
 
+	gofuzz "github.com/google/gofuzz"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -26,6 +28,8 @@ import (
 	"github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cel"
 )
 
+const fuzzIterations = 100
+
 func TestIntegrationCELChecks(t *testing.T) {
 	for _, tc := range []struct {
 		title          string
@@ -204,7 +208,7 @@ func TestIntegrationCELChecks(t *testing.T) {
 			unstructuredObject, err := runtime.DefaultUnstructuredConverter.ToUnstructured(&tc.obj)
 			require.NoError(t, err)
 
-			crdPath := "../../next-crds/atlas.nextapi.mongodb.com_atlasthirdpartyintegrations.yaml"
+			crdPath := "../../config/crd/bases/atlas.mongodb.com_atlasthirdpartyintegrations.yaml"
 			validator, err := cel.VersionValidatorFromFile(t, crdPath, "v1")
 			assert.NoError(t, err)
 			errs := validator(unstructuredObject, nil)
@@ -213,3 +217,15 @@ func TestIntegrationCELChecks(t *testing.T) {
 		})
 	}
 }
+
+func FuzzIntegrationCloning(f *testing.F) {
+	for i := uint(0); i < fuzzIterations; i++ {
+		f.Add(([]byte)(fmt.Sprintf("seed sample %x", i)), i)
+	}
+	f.Fuzz(func(t *testing.T, data []byte, index uint) {
+		integrationData := &AtlasThirdPartyIntegration{}
+		gofuzz.NewFromGoFuzz(data).Fuzz(integrationData)
+		copy := integrationData.DeepCopy()
+		assert.Equal(t, integrationData, copy, "failed copy for index=%d", index)
+	})
+}