SERVER-48600 refineCollectionShardKey internal transaction should check for write concern errors

Author: jsmulrow

src/mongo/db/s/config/sharding_catalog_manager_collection_operations.cpp

@@ -226,7 +226,11 @@ Status commitTxnForConfigDocument(OperationContext* opCtx, TxnNumber txnNumber)
                               .get()
                               .response);
 
-    return getStatusFromCommandResult(replyOpMsg.body);
+    auto commandStatus = getStatusFromCommandResult(replyOpMsg.body);
+    if (!commandStatus.isOK()) {
+        return commandStatus;
+    }
+    return getWriteConcernStatusFromCommandResult(replyOpMsg.body);
 }
 
 void triggerFireAndForgetShardRefreshes(OperationContext* opCtx, const NamespaceString& nss) {
@@ -702,6 +706,7 @@ void ShardingCatalogManager::refineCollectionShardKey(OperationContext* opCtx,
             hangRefineCollectionShardKeyBeforeCommit.pauseWhileSet(opCtx);
         }
 
+        // Note this will wait for majority write concern.
         uassertStatusOK(commitTxnForConfigDocument(asr.opCtx(), txnNumber));
     }