Import wiredtiger: 39757ea990f11e884aecbe5fe86648389f26feb6 from branch mongodb-master

ref: 8288276864..39757ea990
for: 7.3.0-rc0

WT-12005 Fix memory leak in __wt_background_compact_signal

Author: lukech

src/third_party/wiredtiger/import.data

@@ -2,5 +2,5 @@
     "vendor": "wiredtiger",
     "github": "wiredtiger/wiredtiger.git",
     "branch": "mongodb-master",
-    "commit": "8288276864b2dc8a03e879c002c6f4f6c0c2f5b0"
+    "commit": "39757ea990f11e884aecbe5fe86648389f26feb6"
 }

src/third_party/wiredtiger/src/conn/conn_compact.c

@@ -727,10 +727,12 @@ __wt_background_compact_signal(WT_SESSION_IMPL *session, const char *config)
     conn->background_compact.running = enable;
     __wt_free(session, conn->background_compact.config);
     conn->background_compact.config = stripped_config;
+    stripped_config = NULL;
     conn->background_compact.signalled = true;
     __wt_cond_signal(session, conn->background_compact.cond);
 
 err:
+    __wt_free(session, stripped_config);
     __wt_spin_unlock(session, &conn->background_compact.lock);
     return (ret);
 }

src/third_party/wiredtiger/test/cppsuite/tests/background_compact.cpp

@@ -300,12 +300,13 @@ class background_compact : public test {
         logger::log_msg(
           LOG_INFO, type_string(tw->type) + " thread {" + std::to_string(tw->id) + "} commencing.");
 
-        bool enabled = false;
-
         while (tw->running()) {
-            enabled = !enabled;
-
-            std::string compact_cfg = enabled ?
+            /*
+             * The API supports enabling or disabling the background compact server multiple times
+             * in a row. Randomly pick whether we are enabling or disabling to cover all state
+             * changes.
+             */
+            std::string compact_cfg = random_generator::instance().generate_bool() ?
               "background=true,free_space_target=" + std::to_string(tw->free_space_target_mb) +
                 "MB" :
               "background=false";

src/third_party/wiredtiger/test/format/compact.c

@@ -63,26 +63,25 @@ background_compact(void *arg)
         if (g.workers_finished)
             break;
 
-        if (g.background_compaction_running)
-            testutil_snprintf(config_buf, sizeof(config_buf), "%s", "background=false");
-        else
+        /*
+         * The API supports enabling or disabling the background compact server multiple times in a
+         * row. Randomly pick whether we are enabling or disabling to cover all state changes.
+         */
+        if (mmrand(&g.extra_rnd, 0, 1))
             testutil_snprintf(config_buf, sizeof(config_buf),
               "background=true,free_space_target=%" PRIu32 "MB",
               GV(BACKGROUND_COMPACT_FREE_SPACE_TARGET));
+        else
+            testutil_snprintf(config_buf, sizeof(config_buf), "%s", "background=false");
 
         ret = session->compact(session, NULL, config_buf);
-        if (ret == 0)
-            g.background_compaction_running = !g.background_compaction_running;
-        else
+        if (ret != 0)
             testutil_assertfmt(ret == EBUSY, "WT_SESSION.compact failed: %d", ret);
     }
 
     /* Always disable the background compaction server. */
-    if (g.background_compaction_running)
-        ret = session->compact(session, NULL, "background=false");
-    if (ret == 0)
-        g.background_compaction_running = false;
-    else
+    ret = session->compact(session, NULL, "background=false");
+    if (ret != 0)
         testutil_assertfmt(ret == EBUSY, "WT_SESSION.compact failed: %d", ret);
 
     wt_wrap_close_session(session);