minor: bump clippy to 1.65 (#789)

Author: isabelatkinson

.evergreen/check-clippy.sh

@@ -6,7 +6,7 @@ source ./.evergreen/configure-rust.sh
 source ./.evergreen/feature-combinations.sh
 
 # Pin clippy to the latest version. This should be updated when new versions of Rust are released.
-CLIPPY_VERSION=1.64.0
+CLIPPY_VERSION=1.65.0
 
 rustup install $CLIPPY_VERSION
 

src/client/auth/mod.rs

@@ -512,7 +512,7 @@ pub(crate) fn generate_nonce_bytes() -> [u8; 32] {
 
 pub(crate) fn generate_nonce() -> String {
     let result = generate_nonce_bytes();
-    base64::encode(&result)
+    base64::encode(result)
 }
 
 fn mac<M: Mac + KeyInit>(

src/concern/mod.rs

@@ -329,7 +329,7 @@ impl WriteConcern {
     /// Whether the write concern was created with no values specified. If true, the write concern
     /// should be considered the server's default.
     pub(crate) fn is_empty(&self) -> bool {
-        self.w == None && self.w_timeout == None && self.journal == None
+        self.w.is_none() && self.w_timeout.is_none() && self.journal.is_none()
     }
 
     /// Validates that the write concern. A write concern is invalid if both the `w` field is 0

src/test/spec/crud_v1/replace_one.rs

@@ -82,7 +82,7 @@ async fn run_replace_one_test(test_file: TestFile) {
 
         assert_eq!(
             outcome.result.upserted_count.unwrap_or(0),
-            if result.upserted_id.is_some() { 1 } else { 0 },
+            u64::from(result.upserted_id.is_some()),
             "{}",
             test_case.description
         );

src/test/spec/crud_v1/update_many.rs

@@ -83,7 +83,7 @@ async fn run_update_many_test(test_file: TestFile) {
 
         assert_eq!(
             outcome.result.upserted_count.unwrap_or(0),
-            if result.upserted_id.is_some() { 1 } else { 0 },
+            u64::from(result.upserted_id.is_some()),
             "{}",
             test_case.description
         );

src/test/spec/crud_v1/update_one.rs

@@ -83,7 +83,7 @@ async fn run_update_one_test(test_file: TestFile) {
 
         assert_eq!(
             outcome.result.upserted_count.unwrap_or(0),
-            if result.upserted_id.is_some() { 1 } else { 0 },
+            u64::from(result.upserted_id.is_some()),
             "{}",
             test_case.description
         );

src/test/util/mod.rs

@@ -480,10 +480,7 @@ struct BuildInfo {
 }
 
 pub(crate) fn get_default_name(description: &str) -> String {
-    let mut db_name = description
-        .replace('$', "%")
-        .replace(' ', "_")
-        .replace('.', "_");
+    let mut db_name = description.replace('$', "%").replace([' ', '.'], "_");
     // database names must have fewer than 38 characters
     db_name.truncate(37);
     db_name