minor: fix clippy

Author: patrickfreed

src/client/auth/plain.rs

@@ -46,9 +46,7 @@ pub(crate) async fn authenticate_stream(
 }
 
 fn payload_bytes(username: &str, password: &str) -> Vec<u8> {
-    let mut bytes = Vec::new();
-
-    bytes.push(0);
+    let mut bytes = vec![0];
     bytes.extend(username.as_bytes());
 
     bytes.push(0);

src/sdam/description/server.rs

@@ -17,6 +17,7 @@ const DRIVER_MAX_WIRE_VERSION: i32 = 7;
 
 #[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[non_exhaustive]
+#[allow(clippy::upper_case_acronyms)]
 pub enum ServerType {
     Standalone,
     Mongos,

src/sdam/description/topology/server_selection/test/mod.rs

@@ -117,6 +117,7 @@ struct LastWriteDate {
 }
 
 #[derive(Clone, Copy, Debug, Deserialize)]
+#[allow(clippy::upper_case_acronyms)]
 enum TestServerType {
     Standalone,
     Mongos,

src/test/spec/auth.rs

@@ -22,16 +22,16 @@ struct TestCredential {
     pub mechanism_properties: Option<Document>,
 }
 
-impl Into<Credential> for TestCredential {
-    fn into(self) -> Credential {
+impl From<TestCredential> for Credential {
+    fn from(test_credential: TestCredential) -> Credential {
         Credential {
-            username: self.username,
-            password: self.password,
-            source: self.source,
-            mechanism: self
+            username: test_credential.username,
+            password: test_credential.password,
+            source: test_credential.source,
+            mechanism: test_credential
                 .mechanism
                 .and_then(|s| AuthMechanism::from_str(s.as_str()).ok()),
-            mechanism_properties: self.mechanism_properties,
+            mechanism_properties: test_credential.mechanism_properties,
         }
     }
 }

src/test/spec/initial_dns_seedlist_discovery.rs

@@ -60,7 +60,7 @@ async fn run() {
         };
 
         if let Some(true) = test_file.error {
-            assert!(matches!(result, Err(_)), test_file.comment.unwrap());
+            assert!(matches!(result, Err(_)), "{}", test_file.comment.unwrap());
             return;
         }
 

src/test/spec/mod.rs

@@ -76,7 +76,7 @@ where
         run_test_file(
             bson::from_bson(
                 Bson::try_from(json)
-                    .unwrap_or_else(|_| panic!(test_file_full_path.display().to_string())),
+                    .unwrap_or_else(|_| panic!("{}", test_file_full_path.display().to_string())),
             )
             .unwrap_or_else(|e| panic!("{}: {}", test_file_full_path.display().to_string(), e)),
         )

src/test/spec/unified_runner/matcher.rs

@@ -273,12 +273,14 @@ async fn array_matching() {
         None,
     ));
 
-    let mut actual: Vec<Bson> = Vec::new();
-    actual.push(Bson::Document(doc! { "x": 1, "y": 1 }));
-    actual.push(Bson::Document(doc! { "x": 2, "y": 2 }));
-    let mut expected: Vec<Bson> = Vec::new();
-    expected.push(Bson::Document(doc! { "x": 1 }));
-    expected.push(Bson::Document(doc! { "x": 2 }));
+    let actual: Vec<Bson> = vec![
+        Bson::Document(doc! { "x": 1, "y": 1 }),
+        Bson::Document(doc! { "x": 2, "y": 2 }),
+    ];
+    let expected: Vec<Bson> = vec![
+        Bson::Document(doc! { "x": 1 }),
+        Bson::Document(doc! { "x": 2 }),
+    ];
     assert!(!results_match(
         Some(&Bson::Array(actual)),
         &Bson::Array(expected),